Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2639493002: MacViews: Enable word lookup for selectable views::Labels and multi-line text. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 5b25f5b97861d5904c5038e2a3576d7012db26e8..6e1701962e0219bed642286e57457a002f93de41 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -1287,43 +1287,6 @@ size_t RenderTextHarfBuzz::GetRunContainingCaret(
return run_list->size();
}
-int RenderTextHarfBuzz::GetLineContainingYCoord(float text_y) {
- if (text_y < 0)
- return -1;
-
- for (size_t i = 0; i < lines().size(); i++) {
- const internal::Line& line = lines()[i];
-
- if (text_y <= line.size.height())
- return i;
- text_y -= line.size.height();
- }
-
- return lines().size();
-}
-
-int RenderTextHarfBuzz::GetLineSegmentContainingXCoord(
- const internal::Line& line,
- float line_x,
- float* offset_relative_segment) {
- DCHECK(offset_relative_segment);
-
- *offset_relative_segment = 0;
- if (line_x < 0)
- return -1;
- for (size_t i = 0; i < line.segments.size(); i++) {
- const internal::LineSegment& segment = line.segments[i];
-
- // segment.x_range is not used because it is in text space.
- if (line_x < segment.width()) {
- *offset_relative_segment = line_x;
- return i;
- }
- line_x -= segment.width();
- }
- return line.segments.size();
-}
-
SelectionModel RenderTextHarfBuzz::FirstSelectionModelInsideRun(
const internal::TextRunHarfBuzz* run) {
size_t position = DisplayIndexToTextIndex(run->range.start());

Powered by Google App Engine
This is Rietveld 408576698