Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: third_party/WebKit/Source/core/editing/commands/UndoStep.h

Issue 2639483002: Add sequence number to undo steps (Closed)
Patch Set: Wed Jan 18 19:11:59 JST 2017 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/UndoStack.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/UndoStep.h
diff --git a/third_party/WebKit/Source/core/editing/commands/UndoStep.h b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
index c0e1935eb3f2bc0a27e8b52c84dbd9b2c710ecde..56aa7fc3968a184d1cc86b46d02d33747659beb0 100644
--- a/third_party/WebKit/Source/core/editing/commands/UndoStep.h
+++ b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
@@ -65,6 +65,9 @@ class UndoStep : public GarbageCollectedFinalized<UndoStep> {
return m_endingRootEditableElement.get();
}
+ uint64_t sequence() const { return m_sequence; }
yosin_UTC9 2017/01/19 06:40:52 s/sequence/sequenceNumber()/ Term "sequence" is a
Xiaocheng 2017/01/19 07:52:30 Will do.
+ void setSequence(uint64_t passedSequence) { m_sequence = passedSequence; }
+
DECLARE_TRACE();
private:
@@ -80,6 +83,7 @@ class UndoStep : public GarbageCollectedFinalized<UndoStep> {
Member<Element> m_startingRootEditableElement;
Member<Element> m_endingRootEditableElement;
InputEvent::InputType m_inputType;
+ uint64_t m_sequence;
yosin_UTC9 2017/01/19 06:40:52 Can we make |const unit64_t m_sequenceNumber| and
Xiaocheng 2017/01/19 07:52:30 For undo steps, is the creation order same as the
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/UndoStack.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698