third_party/WebKit/Source/core/editing/commands/UndoStack.cpp - Issue 2639483002: Add sequence number to undo steps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

Issue 2639483002: Add sequence number to undo steps (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp b/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

index 7f435982f87767a5c40c03c6590b17436a7cefc5..460b6afe82649400ce05ead0929371dc615f969a 100644

--- a/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

@@ -45,6 +45,8 @@ UndoStack* UndoStack::create() {

}

void UndoStack::registerUndoStep(UndoStep* step) {

+ if (m_undoStack.size())

+ DCHECK_GE(step->sequenceNumber(), m_undoStack.back()->sequenceNumber());

if (m_undoStack.size() == maximumUndoStackDepth)

m_undoStack.removeFirst(); // drop oldest item off the far end

if (!m_inRedo)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/UndoStep.h » ('j') | no next file with comments »