Index: chrome/browser/webshare/share_target_pref_helper_unittest.cc |
diff --git a/chrome/browser/webshare/share_target_pref_helper_unittest.cc b/chrome/browser/webshare/share_target_pref_helper_unittest.cc |
new file mode 100644 |
index 0000000000000000000000000000000000000000..5c451d750ef532c5bb574249c0f694f774efbf9a |
--- /dev/null |
+++ b/chrome/browser/webshare/share_target_pref_helper_unittest.cc |
@@ -0,0 +1,222 @@ |
+// Copyright 2017 The Chromium Authors. All rights reserved. |
+// Use of this source code is governed by a BSD-style license that can be |
+// found in the LICENSE file. |
+ |
+#include "base/strings/string16.h" |
+#include "base/strings/string_util.h" |
+#include "base/strings/utf_string_conversions.h" |
+#include "chrome/browser/webshare/share_target_pref_helper.h" |
+#include "chrome/common/pref_names.h" |
+#include "chrome/test/base/testing_profile.h" |
+#include "components/prefs/pref_registry_simple.h" |
+#include "components/prefs/testing_pref_service.h" |
+#include "testing/gtest/include/gtest/gtest.h" |
+ |
+class PrefRegistrySimple; |
+ |
+namespace { |
+ |
+class ShareTargetPrefHelperUnittest : public testing::Test { |
+ protected: |
+ ShareTargetPrefHelperUnittest() {} |
+ ~ShareTargetPrefHelperUnittest() override {} |
+ |
+ void SetUp() override { |
+ pref_service_ = std::unique_ptr<TestingPrefServiceSimple>( |
Matt Giuca
2017/01/25 00:25:54
pref_service_.reset(new TPSS());
Prefer reset ove
constantina
2017/01/25 03:18:27
Done.
|
+ new TestingPrefServiceSimple()); |
+ pref_service_->registry()->RegisterDictionaryPref( |
+ prefs::kWebShareVisitedTargets); |
+ } |
+ |
+ PrefService* pref_service() { return pref_service_.get(); } |
+ |
+ private: |
+ std::unique_ptr<TestingPrefServiceSimple> pref_service_; |
+}; |
+ |
+constexpr char kUrlTemplateKey[] = "url_template"; |
+ |
+TEST_F(ShareTargetPrefHelperUnittest, AddMultipleShareTargets) { |
+ std::string manifest_url; |
Matt Giuca
2017/01/25 00:25:53
nit: I *think* these should be declared along side
constantina
2017/01/25 03:18:27
Acknowledged. I think it makes the subtests look i
Matt Giuca
2017/01/30 03:32:39
I think the thing is you shouldn't be thinking of
constantina
2017/01/31 23:37:06
That makes sense. Done.
|
+ base::Optional<std::string> expected_url_template; |
+ std::string url_template; |
+ const base::DictionaryValue* share_target_dict = nullptr; |
+ const base::DictionaryValue* share_target_info_dict = nullptr; |
+ |
+ // Add a share target to prefs that wasn't previously stored. |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = base::Optional<std::string>("share/?title={title}"); |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+ |
+ // Add second share target to prefs that wasn't previously stored. |
+ manifest_url = "https://www.sharetarget2.com/manifest.json"; |
+ expected_url_template = base::Optional<std::string>("share/?title={title}"); |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(2UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+} |
+ |
+TEST_F(ShareTargetPrefHelperUnittest, AddShareTargetTwice) { |
+ std::string manifest_url; |
Matt Giuca
2017/01/25 00:25:54
Again, just declare these as you need them. (Avoid
constantina
2017/01/25 03:18:27
As I said in last comment, I have to declare them
|
+ base::Optional<std::string> expected_url_template; |
+ std::string url_template; |
+ const base::DictionaryValue* share_target_dict = nullptr; |
+ const base::DictionaryValue* share_target_info_dict = nullptr; |
+ |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = base::Optional<std::string>("share/?title={title}"); |
+ |
+ // Add a share target to prefs that wasn't previously stored. |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+ |
+ // Add same share target to prefs that was previously stored; shouldn't |
+ // duplicate it. |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+} |
+ |
+TEST_F(ShareTargetPrefHelperUnittest, UpdateShareTarget) { |
+ std::string manifest_url; |
+ base::Optional<std::string> expected_url_template; |
+ std::string url_template; |
+ const base::DictionaryValue* share_target_dict = nullptr; |
+ const base::DictionaryValue* share_target_info_dict = nullptr; |
+ |
+ // Add a share target to prefs that wasn't previously stored. |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = base::Optional<std::string>("share/?title={title}"); |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+ |
+ // Add same share target to prefs that was previously stored, with new |
+ // url_template; should update the value. |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = |
+ base::Optional<std::string>("share/?title={title}&text={text}"); |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+} |
+ |
+TEST_F(ShareTargetPrefHelperUnittest, DontAddNonShareTarget) { |
+ std::string manifest_url; |
Matt Giuca
2017/01/25 00:25:54
As with AddShareTarget, these can be constants bec
constantina
2017/01/25 03:18:27
Done.
|
+ base::Optional<std::string> expected_url_template; |
+ std::string url_template; |
+ const base::DictionaryValue* share_target_dict = nullptr; |
+ const base::DictionaryValue* share_target_info_dict = nullptr; |
+ |
+ // Don't add a site that has a null template. |
+ manifest_url = "https://www.dudsharetarget.com/manifest.json"; |
+ expected_url_template = base::nullopt; |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(0UL, share_target_dict->size()); |
+ ASSERT_FALSE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+} |
+ |
+TEST_F(ShareTargetPrefHelperUnittest, RemoveShareTarget) { |
+ std::string manifest_url; |
+ base::Optional<std::string> expected_url_template; |
+ std::string url_template; |
+ const base::DictionaryValue* share_target_dict = nullptr; |
+ const base::DictionaryValue* share_target_info_dict = nullptr; |
+ |
+ // Add a share target to prefs that wasn't previously stored. |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = base::Optional<std::string>("share/?title={title}"); |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(1UL, share_target_dict->size()); |
+ ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
+ manifest_url, &share_target_info_dict)); |
+ EXPECT_EQ(1UL, share_target_info_dict->size()); |
+ EXPECT_TRUE( |
+ share_target_info_dict->GetString(kUrlTemplateKey, &url_template)); |
+ EXPECT_EQ(url_template, expected_url_template); |
+ |
+ // Share target already added now has null template. Remove from prefs. |
+ manifest_url = "https://www.sharetarget.com/manifest.json"; |
+ expected_url_template = base::nullopt; |
+ |
+ AddShareTargetToPrefs(manifest_url, expected_url_template, |
+ pref_service()); |
+ |
+ share_target_dict = |
+ pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
+ EXPECT_EQ(0UL, share_target_dict->size()); |
+} |
+ |
+} // namespace |