OLD | NEW |
(Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. |
| 4 |
| 5 #include "base/strings/string16.h" |
| 6 #include "base/strings/string_util.h" |
| 7 #include "base/strings/utf_string_conversions.h" |
| 8 #include "chrome/browser/webshare/share_target_pref_helper.h" |
| 9 #include "chrome/common/pref_names.h" |
| 10 #include "chrome/test/base/testing_profile.h" |
| 11 #include "components/prefs/pref_registry_simple.h" |
| 12 #include "components/prefs/testing_pref_service.h" |
| 13 #include "testing/gtest/include/gtest/gtest.h" |
| 14 |
| 15 class PrefRegistrySimple; |
| 16 |
| 17 namespace { |
| 18 |
| 19 class ShareTargetPrefHelperUnittest : public testing::Test { |
| 20 protected: |
| 21 ShareTargetPrefHelperUnittest() {} |
| 22 ~ShareTargetPrefHelperUnittest() override {} |
| 23 |
| 24 void SetUp() override { |
| 25 pref_service_.reset(new TestingPrefServiceSimple()); |
| 26 pref_service_->registry()->RegisterDictionaryPref( |
| 27 prefs::kWebShareVisitedTargets); |
| 28 } |
| 29 |
| 30 PrefService* pref_service() { return pref_service_.get(); } |
| 31 |
| 32 private: |
| 33 std::unique_ptr<TestingPrefServiceSimple> pref_service_; |
| 34 }; |
| 35 |
| 36 constexpr char kUrlTemplateKey[] = "url_template"; |
| 37 |
| 38 TEST_F(ShareTargetPrefHelperUnittest, AddMultipleShareTargets) { |
| 39 // Add a share target to prefs that wasn't previously stored. |
| 40 std::string manifest_url = "https://www.sharetarget.com/manifest.json"; |
| 41 base::Optional<std::string> url_template = |
| 42 base::Optional<std::string>("share/?title={title}"); |
| 43 |
| 44 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 45 |
| 46 const base::DictionaryValue* share_target_dict = |
| 47 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 48 EXPECT_EQ(1UL, share_target_dict->size()); |
| 49 const base::DictionaryValue* share_target_info_dict = nullptr; |
| 50 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 51 manifest_url, &share_target_info_dict)); |
| 52 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 53 std::string url_template_in_dict; |
| 54 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 55 &url_template_in_dict)); |
| 56 EXPECT_EQ(url_template_in_dict, url_template); |
| 57 |
| 58 // Add second share target to prefs that wasn't previously stored. |
| 59 manifest_url = "https://www.sharetarget2.com/manifest.json"; |
| 60 url_template = base::Optional<std::string>("share/?title={title}"); |
| 61 |
| 62 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 63 |
| 64 share_target_dict = |
| 65 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 66 EXPECT_EQ(2UL, share_target_dict->size()); |
| 67 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 68 manifest_url, &share_target_info_dict)); |
| 69 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 70 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 71 &url_template_in_dict)); |
| 72 EXPECT_EQ(url_template_in_dict, url_template); |
| 73 } |
| 74 |
| 75 TEST_F(ShareTargetPrefHelperUnittest, AddShareTargetTwice) { |
| 76 const char kManifestUrl[] = "https://www.sharetarget.com/manifest.json"; |
| 77 const base::Optional<std::string> kUrlTemplate = |
| 78 base::Optional<std::string>("share/?title={title}"); |
| 79 |
| 80 // Add a share target to prefs that wasn't previously stored. |
| 81 UpdateShareTargetInPrefs(kManifestUrl, kUrlTemplate, pref_service()); |
| 82 |
| 83 const base::DictionaryValue* share_target_dict = |
| 84 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 85 EXPECT_EQ(1UL, share_target_dict->size()); |
| 86 const base::DictionaryValue* share_target_info_dict = nullptr; |
| 87 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 88 kManifestUrl, &share_target_info_dict)); |
| 89 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 90 std::string url_template_in_dict; |
| 91 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 92 &url_template_in_dict)); |
| 93 EXPECT_EQ(url_template_in_dict, kUrlTemplate); |
| 94 |
| 95 // Add same share target to prefs that was previously stored; shouldn't |
| 96 // duplicate it. |
| 97 UpdateShareTargetInPrefs(kManifestUrl, kUrlTemplate, pref_service()); |
| 98 |
| 99 share_target_dict = |
| 100 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 101 EXPECT_EQ(1UL, share_target_dict->size()); |
| 102 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 103 kManifestUrl, &share_target_info_dict)); |
| 104 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 105 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 106 &url_template_in_dict)); |
| 107 EXPECT_EQ(url_template_in_dict, kUrlTemplate); |
| 108 } |
| 109 |
| 110 TEST_F(ShareTargetPrefHelperUnittest, UpdateShareTarget) { |
| 111 // Add a share target to prefs that wasn't previously stored. |
| 112 std::string manifest_url = "https://www.sharetarget.com/manifest.json"; |
| 113 base::Optional<std::string> url_template = |
| 114 base::Optional<std::string>("share/?title={title}"); |
| 115 |
| 116 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 117 |
| 118 const base::DictionaryValue* share_target_dict = |
| 119 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 120 EXPECT_EQ(1UL, share_target_dict->size()); |
| 121 const base::DictionaryValue* share_target_info_dict = nullptr; |
| 122 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 123 manifest_url, &share_target_info_dict)); |
| 124 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 125 std::string url_template_in_dict; |
| 126 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 127 &url_template_in_dict)); |
| 128 EXPECT_EQ(url_template_in_dict, url_template); |
| 129 |
| 130 // Add same share target to prefs that was previously stored, with new |
| 131 // url_template_in_dict; should update the value. |
| 132 manifest_url = "https://www.sharetarget.com/manifest.json"; |
| 133 url_template = |
| 134 base::Optional<std::string>("share/?title={title}&text={text}"); |
| 135 |
| 136 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 137 |
| 138 share_target_dict = |
| 139 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 140 EXPECT_EQ(1UL, share_target_dict->size()); |
| 141 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 142 manifest_url, &share_target_info_dict)); |
| 143 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 144 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 145 &url_template_in_dict)); |
| 146 EXPECT_EQ(url_template_in_dict, url_template); |
| 147 } |
| 148 |
| 149 TEST_F(ShareTargetPrefHelperUnittest, DontAddNonShareTarget) { |
| 150 const char kManifestUrl[] = "https://www.dudsharetarget.com/manifest.json"; |
| 151 const base::Optional<std::string> kUrlTemplate; |
| 152 |
| 153 // Don't add a site that has a null template. |
| 154 UpdateShareTargetInPrefs(kManifestUrl, kUrlTemplate, pref_service()); |
| 155 |
| 156 const base::DictionaryValue* share_target_dict = |
| 157 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 158 EXPECT_EQ(0UL, share_target_dict->size()); |
| 159 const base::DictionaryValue* share_target_info_dict = nullptr; |
| 160 ASSERT_FALSE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 161 kManifestUrl, &share_target_info_dict)); |
| 162 } |
| 163 |
| 164 TEST_F(ShareTargetPrefHelperUnittest, RemoveShareTarget) { |
| 165 // Add a share target to prefs that wasn't previously stored. |
| 166 std::string manifest_url = "https://www.sharetarget.com/manifest.json"; |
| 167 base::Optional<std::string> url_template = |
| 168 base::Optional<std::string>("share/?title={title}"); |
| 169 |
| 170 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 171 |
| 172 const base::DictionaryValue* share_target_dict = |
| 173 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 174 EXPECT_EQ(1UL, share_target_dict->size()); |
| 175 const base::DictionaryValue* share_target_info_dict = nullptr; |
| 176 ASSERT_TRUE(share_target_dict->GetDictionaryWithoutPathExpansion( |
| 177 manifest_url, &share_target_info_dict)); |
| 178 EXPECT_EQ(1UL, share_target_info_dict->size()); |
| 179 std::string url_template_in_dict; |
| 180 EXPECT_TRUE(share_target_info_dict->GetString(kUrlTemplateKey, |
| 181 &url_template_in_dict)); |
| 182 EXPECT_EQ(url_template_in_dict, url_template); |
| 183 |
| 184 // Share target already added now has null template. Remove from prefs. |
| 185 manifest_url = "https://www.sharetarget.com/manifest.json"; |
| 186 url_template = base::nullopt; |
| 187 |
| 188 UpdateShareTargetInPrefs(manifest_url, url_template, pref_service()); |
| 189 |
| 190 share_target_dict = |
| 191 pref_service()->GetDictionary(prefs::kWebShareVisitedTargets); |
| 192 EXPECT_EQ(0UL, share_target_dict->size()); |
| 193 } |
| 194 |
| 195 } // namespace |
OLD | NEW |