chrome/browser/webshare/share_target_pref_helper.h - Issue 2639463002: Add a pref name for share targets, and store their manifest data.

Side by Side Diff: chrome/browser/webshare/share_target_pref_helper.h

Issue 2639463002: Add a pref name for share targets, and store their manifest data. (Closed)

Patch Set: Separate tests, add .h, as per feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/extensions/bookmark_app_helper.cc ('K') | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/webshare/share_target_pref_helper.cc » ('j') | chrome/browser/webshare/share_target_pref_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_WEBSHARE_SHARE_TARGET_PREF_HELPER_H_

	6 #define CHROME_BROWSER_WEBSHARE_SHARE_TARGET_PREF_HELPER_H_

	7

	8 #include "base/optional.h"

	9 #include "base/strings/string_piece.h"

	10 #include "base/values.h"
	Matt Giuca 2017/01/24 03:26:09 This isn't needed here -- move it into the .cc fil This isn't needed here -- move it into the .cc file. constantina 2017/01/24 23:39:04 Done. Show quoted text On 2017/01/24 03:26:09, Matt Giuca wrote: > This isn't needed here -- move it into the .cc file. Done.
	11 #include "components/prefs/pref_service.h"
	Matt Giuca 2017/01/24 03:26:09 This can be forward-declared, since you only refer This can be forward-declared, since you only refer to it from a function and it is just an ordinary class (unlike StringPiece which is a typedef, and Optional which is templated). Add "class PrefService;" and move this #include into the .cc file. constantina 2017/01/24 23:39:04 Done. Show quoted text On 2017/01/24 03:26:09, Matt Giuca wrote: > This can be forward-declared, since you only refer to it from a function and it > is just an ordinary class (unlike StringPiece which is a typedef, and Optional > which is templated). > > Add "class PrefService;" and move this #include into the .cc file. Done.
	12 #include "components/prefs/scoped_user_pref_update.h"
	Matt Giuca 2017/01/24 03:26:09 This isn't needed. This isn't needed. constantina 2017/01/24 23:39:04 Done. Show quoted text On 2017/01/24 03:26:09, Matt Giuca wrote: > This isn't needed. Done.
	13 #include "content/public/common/manifest.h"
	Matt Giuca 2017/01/24 03:26:09 Nor is this. Only include headers you need to ref Nor is this. Only include headers you need to refer to in the header (not the .cc file). And don't include the same header from both the .h and .cc file. constantina 2017/01/24 23:39:04 Done. Show quoted text On 2017/01/24 03:26:09, Matt Giuca wrote: > Nor is this. > > Only include headers you need to refer to in the header (not the .cc file). And > don't include the same header from both the .h and .cc file. Done.
	14

	15 namespace webshare {

	16

	17 // Adds the Web Share target \|share_target_origin\| with template \|url_template\|

	18 // to \|pref_service\| under kWebShareVisitedTargets. If \|url_template\| is null,

	19 // this function will remove \|share_target_origin\| from kWebShareVisitedTargets,

	20 // if it is there.

	21 void AddShareTargetToPrefs(base::StringPiece share_target_origin,
	Matt Giuca 2017/01/24 03:26:09 This is no longer an origin, but a full URL to the This is no longer an origin, but a full URL to the manifest. constantina 2017/01/24 23:39:04 Done. Show quoted text On 2017/01/24 03:26:09, Matt Giuca (OOO til Jan 30) wrote: > This is no longer an origin, but a full URL to the manifest. Done.
	22 base::Optional<std::string> url_template,

	23 PrefService* pref_service);

	24

	25 } // namespace webshare

	26

	27 #endif // CHROME_BROWSER_WEBSHARE_SHARE_TARGET_PREF_HELPER_H_

OLD	NEW