Add a pref name for share targets, and store their manifest data.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_font_webkit_names.h"
@@ skipping 2343 matching lines @@
 // Whether the metrics for the state of geolocation post-disclosure being shown
 // have been recorded.
 const char kSearchGeolocationPostDisclosureMetricsRecorded[] =
     "search_geolocation_post_disclosure_metrics_recorded";
 #endif
 
 // A dictionary which stores whether location access is enabled for the current
 // default search engine, if it is the Google search engine.
 const char kGoogleDSEGeolocationSetting[] = "google_dse_geolocation_setting";
 
+#if defined(OS_WIN) || defined(OS_LINUX)

[Matt Giuca, 2017/01/23 03:01:00]

Again, don't qualify this for specific OSes.

[constantina, 2017/01/24 02:03:43]

Done.

+// A dictionary of domains of Web Share Targets to their share_url_template

[Matt Giuca, 2017/01/23 03:00:59]

Not really their url template... it maps to a dict containing a copy of the
"share_target" section of the manifest.

[constantina, 2017/01/24 02:03:43]

Done.

+// found in their manifest.
+const char kWebShareVisitedTargets[] = "profile.web_share.visited_targets";

[Matt Giuca, 2017/01/23 03:00:58]

Can we call this "registered_targets" instead of visited? Because if we change
it in the future to require explicit user interaction, I imagine we won't store
things here until the user asks for it, right?

[constantina, 2017/01/24 02:03:43]

If I change the pref name without changing the functionality, I fear that
someone reading the code as it is will be confused/make assumption about the
functionality. Added a TODO instead.

[Matt Giuca, 2017/01/24 03:26:09]

The problem is that it's really hard to change a pref name (without deleting all
the data). I guess it's a question of whether *if* we change to explicit
registration if we want to clear out all the existing visited ones. And... I
guess we do?

OK in that case just remove the TODO. We don't have a solid plan for this and it
currently does what it says it does. That's sufficient.

[constantina, 2017/01/24 23:39:04]

Done.

+#endif
+
 }  // namespace prefs