Add a pref name for share targets, and store their manifest data.

chrome/browser/extensions/bookmark_app_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.

[Matt Giuca, 2017/01/23 03:04:12]

Comment about the CL description:

- The first line should describe briefly the WHOLE CL. "Add a pref name" doesn't
capture that you are actually recording things into the pref with this same CL.
Make a brief summary, then go into details.

- Remove "Dependant on" line. That will not be true once this lands, it's only
true now because that CL hasn't landed yet. Reviewers can see that it's
dependent from the dependency information below the patch set.

[constantina, 2017/01/24 02:03:42]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 
 #include <stddef.h>
 
 #include <cctype>
 #include <string>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/favicon_downloader.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/app_list_util.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/web_applications/web_app.h"
+#include "chrome/browser/webshare/share_target_pref_helper.cc"

[Matt Giuca, 2017/01/23 03:00:57]

You can't include a .cc file. Need a header file.

(Did you make a header file but forgot to add it, or is there only a .cc file?)

[constantina, 2017/01/24 02:03:42]

Ah yeah, I just wanted to get it to work. Added header file and included it
everywhere necessary.

 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
+#include "chrome/common/origin_trials/chrome_origin_trial_policy.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/platform_locale_settings.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/image_loader.h"
@@ skipping 533 matching lines @@
   OnDidGetManifest(GURL(), manifest);
 }
 
 void BookmarkAppHelper::OnDidGetManifest(const GURL& manifest_url,
                                          const content::Manifest& manifest) {
   if (contents_->IsBeingDestroyed())
     return;
 
   UpdateWebAppInfoFromManifest(manifest, &web_app_info_);
 
+  if (!ChromeOriginTrialPolicy().IsFeatureDisabled("WebShare")) {
+    AddShareTargetToPrefs(manifest_url.GetOrigin().spec(),
+                       manifest.share_target.url_template,

[mlamouri (slow - plz ping), 2017/01/23 00:24:06]

Following up from my comment on the manifest's CL, maybe this should be:
```
if (!ChromeOriginTrialPolicy().IsFeatureDisabled("WebShare") &&
manifest.share_target.has_value()) {
  AddShareTargetToPrefs(manifest_url.GetOrigin().spec(),
                        manifest.share_target.value().url_template,
                        profile_->GetPrefs());
}
```

[Matt Giuca, 2017/01/23 03:00:57]

Needs formatting (some alignment issue).

[constantina, 2017/01/24 02:03:42]

Done.

[constantina, 2017/01/24 02:03:42]

Done.

+                       profile_->GetPrefs());
+  }
+
   // Add urls from the WebApplicationInfo.
   std::vector<GURL> web_app_info_icon_urls;
   for (std::vector<WebApplicationInfo::IconInfo>::const_iterator it =
            web_app_info_.icons.begin();
        it != web_app_info_.icons.end();
        ++it) {
     if (it->url.is_valid())
       web_app_info_icon_urls.push_back(it->url);
   }
 
@@ skipping 212 matching lines @@
       extension, info_list, base::Bind(&OnIconsLoaded, web_app_info, callback));
 }
 
 bool IsValidBookmarkAppUrl(const GURL& url) {
   URLPattern origin_only_pattern(Extension::kValidBookmarkAppSchemes);
   origin_only_pattern.SetMatchAllURLs(true);
   return url.is_valid() && origin_only_pattern.MatchesURL(url);
 }
 
 }  // namespace extensions