Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2639423003: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkWaterfallColumn = class extends UI.VBox { 7 Network.NetworkWaterfallColumn = class extends UI.VBox {
8 /** 8 /**
9 * @param {number} rowHeight 9 * @param {number} rowHeight
10 * @param {!Network.NetworkTimeCalculator} calculator 10 * @param {!Network.NetworkTimeCalculator} calculator
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 352
353 /** 353 /**
354 * @param {!SDK.NetworkRequest} request 354 * @param {!SDK.NetworkRequest} request
355 * @return {string} 355 * @return {string}
356 */ 356 */
357 _borderColorForResourceType(request) { 357 _borderColorForResourceType(request) {
358 var resourceType = request.resourceType(); 358 var resourceType = request.resourceType();
359 if (this._borderColorsForResourceTypeCache.has(resourceType)) 359 if (this._borderColorsForResourceTypeCache.has(resourceType))
360 return this._borderColorsForResourceTypeCache.get(resourceType); 360 return this._borderColorsForResourceTypeCache.get(resourceType);
361 var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourc eType; 361 var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourc eType;
362 var color = colorsForResourceType[resourceType] || colorsForResourceType.Oth er; 362 var color = colorsForResourceType[resourceType] || colorsForResourceType.oth er;
363 var parsedColor = Common.Color.parse(color); 363 var parsedColor = Common.Color.parse(color);
364 var hsla = parsedColor.hsla(); 364 var hsla = parsedColor.hsla();
365 hsla[1] /= 2; 365 hsla[1] /= 2;
366 hsla[2] -= Math.min(hsla[2], 0.2); 366 hsla[2] -= Math.min(hsla[2], 0.2);
367 var resultColor = /** @type {string} */ (parsedColor.asString(null)); 367 var resultColor = /** @type {string} */ (parsedColor.asString(null));
368 this._borderColorsForResourceTypeCache.set(resourceType, resultColor); 368 this._borderColorsForResourceTypeCache.set(resourceType, resultColor);
369 return resultColor; 369 return resultColor;
370 } 370 }
371 371
372 /** 372 /**
373 * @param {!CanvasRenderingContext2D} context 373 * @param {!CanvasRenderingContext2D} context
374 * @param {!SDK.NetworkRequest} request 374 * @param {!SDK.NetworkRequest} request
375 * @return {string|!CanvasGradient} 375 * @return {string|!CanvasGradient}
376 */ 376 */
377 _colorForResourceType(context, request) { 377 _colorForResourceType(context, request) {
378 var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourc eType; 378 var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourc eType;
379 var resourceType = request.resourceType(); 379 var resourceType = request.resourceType();
380 var color = colorsForResourceType[resourceType] || colorsForResourceType.Oth er; 380 var color = colorsForResourceType[resourceType] || colorsForResourceType.oth er;
381 if (request.cached()) 381 if (request.cached())
382 return color; 382 return color;
383 383
384 if (this._colorsForResourceTypeCache.has(color)) 384 if (this._colorsForResourceTypeCache.has(color))
385 return this._colorsForResourceTypeCache.get(color); 385 return this._colorsForResourceTypeCache.get(color);
386 var parsedColor = Common.Color.parse(color); 386 var parsedColor = Common.Color.parse(color);
387 var hsla = parsedColor.hsla(); 387 var hsla = parsedColor.hsla();
388 hsla[1] -= Math.min(hsla[1], 0.28); 388 hsla[1] -= Math.min(hsla[1], 0.28);
389 hsla[2] -= Math.min(hsla[2], 0.15); 389 hsla[2] -= Math.min(hsla[2], 0.15);
390 var gradient = context.createLinearGradient(0, 0, 0, this._getBarHeight()); 390 var gradient = context.createLinearGradient(0, 0, 0, this._getBarHeight());
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 return this._rowStripeColor; 603 return this._rowStripeColor;
604 } 604 }
605 } 605 }
606 }; 606 };
607 607
608 /** 608 /**
609 * @typedef {{requests: !Array<!SDK.NetworkRequest>, navigationRequest: ?SDK.Net workRequest}} 609 * @typedef {{requests: !Array<!SDK.NetworkRequest>, navigationRequest: ?SDK.Net workRequest}}
610 */ 610 */
611 Network.NetworkWaterfallColumn.RequestData; 611 Network.NetworkWaterfallColumn.RequestData;
612 612
613 /** @enum {string} */
613 Network.NetworkWaterfallColumn._colorsForResourceType = { 614 Network.NetworkWaterfallColumn._colorsForResourceType = {
614 document: 'hsl(215, 100%, 80%)', 615 document: 'hsl(215, 100%, 80%)',
615 font: 'hsl(8, 100%, 80%)', 616 font: 'hsl(8, 100%, 80%)',
616 media: 'hsl(90, 50%, 80%)', 617 media: 'hsl(90, 50%, 80%)',
617 image: 'hsl(90, 50%, 80%)', 618 image: 'hsl(90, 50%, 80%)',
618 script: 'hsl(31, 100%, 80%)', 619 script: 'hsl(31, 100%, 80%)',
619 stylesheet: 'hsl(272, 64%, 80%)', 620 stylesheet: 'hsl(272, 64%, 80%)',
620 texttrack: 'hsl(8, 100%, 80%)', 621 texttrack: 'hsl(8, 100%, 80%)',
621 websocket: 'hsl(0, 0%, 95%)', 622 websocket: 'hsl(0, 0%, 95%)',
622 xhr: 'hsl(53, 100%, 80%)', 623 xhr: 'hsl(53, 100%, 80%)',
623 other: 'hsl(0, 0%, 95%)' 624 other: 'hsl(0, 0%, 95%)'
624 }; 625 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698