Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2639403003: Remove Last 1 pages when the tab holding them is destroyed. (Closed)
Patch Set: Adds a test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index cbe92b54be1300b6dede26246975b74711c82e41..2176c51a18016dc00500a9981eae362cb828614e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -521,6 +521,10 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
@Override
public void onDestroyed(Tab tab) {
mDataUseSnackbarController.dismissDataUseBar();
+ // We can't use TabModelObserver#tabClosureCommitted to observe closing a
+ // tab because neither the tab model nor the tab have a profile at that
+ // point. So we listen to TabObserver#onDestroyed for that information.
+ OfflinePageBridge.onTabDestroyed(tab);
}
@Override
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698