[Autofill] Remove direct use of base::Time::Now() in Autofill

components/autofill/core/browser/autofill_clock.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.

[Mathieu, 2017/01/25 19:57:24]

+4

[sebsg, 2017/01/25 21:35:27]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/autofill_clock.h"

[Mathieu, 2017/01/25 19:57:24]

does it make sense to have this in core/common?

[sebsg, 2017/01/25 21:35:27]

Done.

+
+#include "base/time/clock.h"
+#include "base/time/default_clock.h"
+
+namespace autofill {
+
+static base::LazyInstance<AutofillClock> instance_ = LAZY_INSTANCE_INITIALIZER;

[Mathieu, 2017/01/25 19:57:24]

can this be in the anonymous namespace?

[Mathieu, 2017/01/25 19:57:24]

naming style is probably to have g_autofill_clock (check other lazy instances).
Otherwise you are adding |instance_| in the autofill namespace...

[sebsg, 2017/01/25 21:35:26]

Done.

[sebsg, 2017/01/25 21:35:27]

Done.

+
+// static
+base::Time AutofillClock::Now() {
+  return instance_.Get().clock_->Now();
+}
+
+AutofillClock::AutofillClock() {
+  clock_ = base::MakeUnique<base::DefaultClock>();

[Mathieu, 2017/01/25 19:57:24]

I prefer the style 

clock_.reset(new base::DefaultClock);

[sebsg, 2017/01/25 21:35:27]

Done.

+}
+
+AutofillClock::~AutofillClock() {}
+
+// static
+void AutofillClock::SetClockForTests(base::Clock* clock) {

[Mathieu, 2017/01/25 19:57:24]

probably better to pass a std::unique_ptr? makes ownership transfer more
explicit

[sebsg, 2017/01/25 21:35:27]

True, thanks for the suggestion.

+  instance_.Get().clock_.reset(clock);
+}
+
+}  // namespace autofill