[Autofill] Remove direct use of base::Time::Now() in Autofill

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 16 matching lines @@
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_profile_comparator.h"
 #include "components/autofill/core/browser/country_data.h"
 #include "components/autofill/core/browser/country_names.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/personal_data_manager_observer.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/browser/phone_number_i18n.h"
 #include "components/autofill/core/browser/validation.h"
+#include "components/autofill/core/common/autofill_clock.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/autofill_util.h"
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/signin/core/common/signin_pref_names.h"
 #include "components/sync/driver/sync_service.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/version_info/version_info.h"
@@ skipping 730 matching lines @@
 void PersonalDataManager::Refresh() {
   LoadProfiles();
   LoadCreditCards();
 }
 
 const std::vector<AutofillProfile*> PersonalDataManager::GetProfilesToSuggest()
     const {
   std::vector<AutofillProfile*> profiles = GetProfiles(true);
 
   // Rank the suggestions by frecency (see AutofillDataModel for details).
-  base::Time comparison_time = base::Time::Now();
+  base::Time comparison_time = AutofillClock::Now();
   std::sort(profiles.begin(), profiles.end(),
             [comparison_time](const AutofillDataModel* a,
                               const AutofillDataModel* b) {
               return a->CompareFrecency(b, comparison_time);
             });
 
   return profiles;
 }
 
 std::vector<Suggestion> PersonalDataManager::GetProfileSuggestions(
@@ skipping 103 matching lines @@
                                          credit_cards.end());
 
   DedupeCreditCardToSuggest(&cards_to_dedupe);
 
   std::vector<CreditCard*> cards_to_suggest(
       std::make_move_iterator(std::begin(cards_to_dedupe)),
       std::make_move_iterator(std::end(cards_to_dedupe)));
 
   // Rank the cards by frecency (see AutofillDataModel for details). All expired
   // cards should be suggested last, also by frecency.
-  base::Time comparison_time = base::Time::Now();
+  base::Time comparison_time = AutofillClock::Now();
   std::stable_sort(cards_to_suggest.begin(), cards_to_suggest.end(),
                    [comparison_time](const CreditCard* a, const CreditCard* b) {
                      bool a_is_expired = a->IsExpired(comparison_time);
                      if (a_is_expired != b->IsExpired(comparison_time))
                        return !a_is_expired;
 
                      return a->CompareFrecency(b, comparison_time);
                    });
 
   return cards_to_suggest;
@@ skipping 62 matching lines @@
     std::vector<std::unique_ptr<AutofillProfile>>* existing_profiles,
     const std::string& app_locale,
     std::vector<AutofillProfile>* merged_profiles) {
   merged_profiles->clear();
 
   // Sort the existing profiles in decreasing order of frecency, so the "best"
   // profiles are checked first. Put the verified profiles last so the non
   // verified profiles get deduped among themselves before reaching the verified
   // profiles.
   // TODO(crbug.com/620521): Remove the check for verified from the sort.
-  base::Time comparison_time = base::Time::Now();
+  base::Time comparison_time = AutofillClock::Now();
   std::sort(existing_profiles->begin(), existing_profiles->end(),
             [comparison_time](const std::unique_ptr<AutofillProfile>& a,
                               const std::unique_ptr<AutofillProfile>& b) {
               if (a->IsVerified() != b->IsVerified())
                 return !a->IsVerified();
               return a->CompareFrecency(b.get(), comparison_time);
             });
 
   // Set to true if |existing_profiles| already contains an equivalent profile.
   bool matching_profile_found = false;
@@ skipping 12 matching lines @@
       // data.  If an automatically aggregated profile would overwrite a
       // verified profile, just drop it.
       matching_profile_found = true;
       guid = existing_profile->guid();
 
       // We set the modification date so that immediate requests for profiles
       // will properly reflect the fact that this profile has been modified
       // recently. After writing to the database and refreshing the local copies
       // the profile will have a very slightly newer time reflecting what's
       // actually stored in the database.
-      existing_profile->set_modification_date(base::Time::Now());
+      existing_profile->set_modification_date(AutofillClock::Now());
     }
     merged_profiles->push_back(*existing_profile);
   }
 
   // If the new profile was not merged with an existing one, add it to the list.
   if (!matching_profile_found) {
     merged_profiles->push_back(new_profile);
     // Similar to updating merged profiles above, set the modification date on
     // new profiles.
-    merged_profiles->back().set_modification_date(base::Time::Now());
+    merged_profiles->back().set_modification_date(AutofillClock::Now());
     AutofillMetrics::LogProfileActionOnFormSubmitted(
         AutofillMetrics::NEW_PROFILE_CREATED);
   }
 
   return guid;
 }
 
 bool PersonalDataManager::IsCountryOfInterest(const std::string& country_code)
     const {
   DCHECK_EQ(2U, country_code.size());
@@ skipping 606 matching lines @@
 
 void PersonalDataManager::ApplyProfileUseDatesFix() {
   // Don't run if the fix has already been applied.
   if (pref_service_->GetBoolean(prefs::kAutofillProfileUseDatesFixed))
     return;
 
   std::vector<AutofillProfile> profiles;
   bool has_changed_data = false;
   for (AutofillProfile* profile : web_profiles()) {
     if (profile->use_date() == base::Time()) {
-      profile->set_use_date(base::Time::Now() - base::TimeDelta::FromDays(14));
+      profile->set_use_date(AutofillClock::Now() -
+                            base::TimeDelta::FromDays(14));
       has_changed_data = true;
     }
     profiles.push_back(*profile);
   }
 
   // Set the pref so that this fix is never run again.
   pref_service_->SetBoolean(prefs::kAutofillProfileUseDatesFixed, true);
 
   if (has_changed_data)
     SetProfiles(&profiles);
@@ skipping 60 matching lines @@
   AutofillMetrics::LogNumberOfProfilesConsideredForDedupe(
       existing_profiles->size());
 
   // Sort the profiles by frecency with all the verified profiles at the end.
   // That way the most relevant profiles will get merged into the less relevant
   // profiles, which keeps the syntax of the most relevant profiles data.
   // Verified profiles are put at the end because they do not merge into other
   // profiles, so the loop can be stopped when we reach those. However they need
   // to be in the vector because an unverified profile trying to merge into a
   // similar verified profile will be discarded.
-  base::Time comparison_time = base::Time::Now();
+  base::Time comparison_time = AutofillClock::Now();
   std::sort(existing_profiles->begin(), existing_profiles->end(),
             [comparison_time](const std::unique_ptr<AutofillProfile>& a,
                               const std::unique_ptr<AutofillProfile>& b) {
               if (a->IsVerified() != b->IsVerified())
                 return !a->IsVerified();
               return a->CompareFrecency(b.get(), comparison_time);
             });
 
   AutofillProfileComparator comparator(app_locale_);
 
@@ skipping 93 matching lines @@
     if (was_modified) {
       if (credit_card->record_type() == CreditCard::LOCAL_CARD)
         database_->UpdateCreditCard(*credit_card);
       else
         database_->UpdateServerCardMetadata(*credit_card);
     }
   }
 }
 
 }  // namespace autofill