Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7091)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)
Patch Set: add bug link to clarify comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 8b4b3825d6db6c3653c0bcacd616e95f4d541224..6cc97e255b8b431a4b5da7a85d2bed1b246abe31 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -78,6 +78,11 @@
-webkit-margin-start: 4px;
}
+ [is='action-link'] {
+ @apply(--settings-actionable);
+ text-decoration: none;
+ }
+
[is='action-link'],
[is='action-link']:active,
[is='action-link']:hover,
@@ -95,11 +100,17 @@
};
}
- a[href],
- [is='action-link']:hover {
+ a[href] {
text-decoration: none;
}
+ [is='action-link'][disabled] {
+ color: var(--paper-grey-600);
+ cursor: default;
+ opacity: var(--settings-disabled-opacity);
+ pointer-events: none;
+ }
+
/* There are three main button styles, .primary-button, .secondary-button,
* and .tertiary-button. The primary is the action button (e.g. "edit",
* "delete") while the secondary is often a "Cancel" button. A tertiary
@@ -221,10 +232,11 @@
}
/* This button has no ink ripple. */
- .list-item.list-button {
- @apply(--settings-actionable);
+ .list-button[is='action-link'] {
+ min-height: inherit;
Dan Beam 2017/01/23 20:40:09 alphabetize
+ display: flex;
align-items: center;
- color: var(--google-blue-500);
+ flex: 1;
font-weight: 500;
}

Powered by Google App Engine
This is Rietveld 408576698