chrome/browser/resources/settings/search_engines_page/search_engines_page.html - Issue 2639373002: MD Settings: clean up text controls (links, buttons)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)

Patch Set: move comment about action_link_css to action_likn_css.html Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | ui/webui/resources/html/action_link_css.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

index 35a512fc788c0d5496f914c556ae3f15fb08ef60..bae938aeaeeead762d13170dfb7e1b21c98912a5 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

@@ -1,6 +1,7 @@

+<link rel="import" href="chrome://resources/html/polymer.html">

+<link rel="import" href="chrome://resources/html/action_link_css.html">

-<link rel="import" href="chrome://resources/html/polymer.html">

@@ -9,9 +10,8 @@

<dom-module id="settings-search-engines-page">

- <link rel="import" type="css" href="chrome://resources/css/action_link.css">

- <style include="settings-shared">

+ <style include="settings-shared action-link">

.extension-engines {

@apply(--settings-list-frame-padding);

}

@@ -35,12 +35,12 @@

<h2>$i18n{searchEnginesOther}</h2>

</div>

- <!-- TODO(dbeam): why does on-click work with keyboard but on-tap

- doesn't? -->

<settings-search-engines-list engines="[[otherEngines]]">

- <a class="list-item list-button" is="action-link"

- on-tap="onAddSearchEngineTap_" id="addSearchEngine">

- $i18n{searchEnginesAddSearchEngine}</a>

+ <div class="list-item" id="addSearchEngine">

+ <a is="action-link" class="list-button" on-tap="onAddSearchEngineTap_">

+ $i18n{searchEnginesAddSearchEngine}

+ </a>

+ </div>

</settings-search-engines-list>