chrome/browser/resources/settings/people_page/lock_screen.html - Issue 2639373002: MD Settings: clean up text controls (links, buttons)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/lock_screen.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)

Patch Set: add comment for action_link_css Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_summary_item.html ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/browser/resources/settings/people_page/users_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/lock_screen.html

diff --git a/chrome/browser/resources/settings/people_page/lock_screen.html b/chrome/browser/resources/settings/people_page/lock_screen.html

index cf290e9fb9302b6f7d1dfcd3a2450b7c84463eb1..9c57b4938ce4ae2ea41d91c8533e8479018fff31 100644

--- a/chrome/browser/resources/settings/people_page/lock_screen.html

+++ b/chrome/browser/resources/settings/people_page/lock_screen.html

@@ -1,6 +1,8 @@

+<link rel="import" href="chrome://resources/html/action_link.html">

+

+<link rel="import" href="chrome://resources/html/action_link_css.html">

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">

@@ -13,14 +15,10 @@

<dom-module id="settings-lock-screen">

- <style include="settings-shared"></style>

+ <style include="settings-shared action-link"></style>

<style>

.radio-indent {

- margin-left: 28px;

- }

- paper-button {

- text-transform: none;

+ margin-left: 36px;

}

</style>

@@ -33,15 +31,13 @@

<paper-radio-button name="pin+password">

$i18n{lockScreenPinOrPassword}

</paper-radio-button>

- <div class="settings-box continuation radio-indent"

- hidden$="[[!showConfigurePinButton_(selectedUnlockType)]]">

- <!-- TODO(dbeam): I seriously doubt paper-button[is=action-link] is

- a good idea. -->

- <paper-button is="action-link" on-tap="onConfigurePin_">

- [[getSetupPinText_(hasPin)]]

- </paper-button>

- </div>

</paper-radio-group>

+ <div class="list-item radio-indent"

+ hidden$="[[!showConfigurePinButton_(selectedUnlockType)]]">

+ <a is="action-link" class="list-button" on-tap="onConfigurePin_">

+ [[getSetupPinText_(hasPin)]]

+ </a>

+ </div>

</div>