chrome/browser/resources/settings/settings_shared_css.html - Issue 2639373002: MD Settings: clean up text controls (links, buttons)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)

Patch Set: move action_link specific stuff to resources/html/action_link_css.html Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/privacy_page/privacy_page.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engines_page.html ('k') | chrome/browser/resources/settings/site_settings/site_details.html » ('j') | chrome/browser/resources/settings/site_settings/site_details.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_shared_css.html

diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html

index 8b4b3825d6db6c3653c0bcacd616e95f4d541224..cb6a228a0ef8cd3fdf642ab29774bf973acf2825 100644

--- a/chrome/browser/resources/settings/settings_shared_css.html

+++ b/chrome/browser/resources/settings/settings_shared_css.html

@@ -78,10 +78,6 @@

-webkit-margin-start: 4px;

}

- [is='action-link'],

- [is='action-link']:active,

- [is='action-link']:hover,

- [is='action-link']:visited,

.primary-button,

.tertiary-button,

a[href] {

@@ -95,8 +91,7 @@

};

}

- a[href],

- [is='action-link']:hover {

+ a[href] {

text-decoration: none;

}

@@ -221,10 +216,11 @@

}

/* This button has no ink ripple. */

- .list-item.list-button {

- @apply(--settings-actionable);

+ .list-button[is='action-link'] {

Dan Beam 2017/01/24 05:25:33 why can't this be .list-item [is='action-link']?

scottchen 2017/01/24 19:39:12 I'm thinking there could be cases in which action-

+ min-height: inherit;

+ display: flex;

align-items: center;

- color: var(--google-blue-500);

+ flex: 1;

font-weight: 500;

}