Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)
Patch Set: add bug link to clarify comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/cr.html"> 3 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 <paper-button on-tap="onRestartTap_"> 118 <paper-button on-tap="onRestartTap_">
119 $i18n{restart} 119 $i18n{restart}
120 </paper-button> 120 </paper-button>
121 </template> 121 </template>
122 </if> 122 </if>
123 <paper-icon-button id="more-[[item.language.code]]" 123 <paper-icon-button id="more-[[item.language.code]]"
124 icon="cr:more-vert" on-tap="onDotsTap_"> 124 icon="cr:more-vert" on-tap="onDotsTap_">
125 </paper-icon-button> 125 </paper-icon-button>
126 </div> 126 </div>
127 </template> 127 </template>
128 <div class="list-item list-button" on-tap="onAddLanguagesTap_"> 128 <div class="list-item">
129 <a is="action-link">$i18n{addLanguages}</a> 129 <a is="action-link" class="list-button"
130 on-tap="onAddLanguagesTap_">
131 $i18n{addLanguages}
132 </a>
130 </div> 133 </div>
131 </div> 134 </div>
132 </iron-collapse> 135 </iron-collapse>
133 <if expr="chromeos"> 136 <if expr="chromeos">
134 <div id="manageInputMethodsSubpageTrigger" 137 <div id="manageInputMethodsSubpageTrigger"
135 class="settings-box two-line" actionable 138 class="settings-box two-line" actionable
136 on-tap="toggleExpandButton_"> 139 on-tap="toggleExpandButton_">
137 <div class="start"> 140 <div class="start">
138 <div>$i18n{inputMethodsListTitle}</div> 141 <div>$i18n{inputMethodsListTitle}</div>
139 <div class="secondary"> 142 <div class="secondary">
(...skipping 20 matching lines...) Expand all
160 item.id, languages.inputMethods.currentId)]]"> 163 item.id, languages.inputMethods.currentId)]]">
161 $i18n{inputMethodEnabled} 164 $i18n{inputMethodEnabled}
162 </div> 165 </div>
163 </div> 166 </div>
164 <paper-icon-button icon="cr:settings" 167 <paper-icon-button icon="cr:settings"
165 on-tap="onInputMethodOptionsTap_" 168 on-tap="onInputMethodOptionsTap_"
166 hidden="[[!item.hasOptionsPage]]"> 169 hidden="[[!item.hasOptionsPage]]">
167 </paper-icon-button> 170 </paper-icon-button>
168 </div> 171 </div>
169 </template> 172 </template>
170 <div class="list-item list-button" 173 <div class="list-item">
171 on-tap="onManageInputMethodsTap_"> 174 <a is="action-link" class="list-button"
172 <a is="action-link">$i18n{manageInputMethods}</a> 175 on-tap="onManageInputMethodsTap_">
176 $i18n{manageInputMethods}
177 </a>
173 </div> 178 </div>
174 </div> 179 </div>
175 </iron-collapse> 180 </iron-collapse>
176 </if> 181 </if>
177 <if expr="not is_macosx"> 182 <if expr="not is_macosx">
178 <div id="spellCheckSubpageTrigger" 183 <div id="spellCheckSubpageTrigger"
179 class$="settings-box [[getSpellCheckListTwoLine_( 184 class$="settings-box [[getSpellCheckListTwoLine_(
180 spellCheckSecondaryText_)]]" 185 spellCheckSecondaryText_)]]"
181 actionable on-tap="toggleExpandButton_"> 186 actionable on-tap="toggleExpandButton_">
182 <div class="start"> 187 <div class="start">
183 <div>$i18n{spellCheckListTitle}</div> 188 <div>$i18n{spellCheckListTitle}</div>
184 <div class="secondary">[[spellCheckSecondaryText_]]</div> 189 <div class="secondary">[[spellCheckSecondaryText_]]</div>
185 </div> 190 </div>
186 <cr-expand-button expanded="{{spellCheckOpened_}}" 191 <cr-expand-button expanded="{{spellCheckOpened_}}"
187 alt="$i18n{spellCheckExpandA11yLabel}"> 192 alt="$i18n{spellCheckExpandA11yLabel}">
188 </cr-expand-button> 193 </cr-expand-button>
189 </div> 194 </div>
190 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]"> 195 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
191 <div class="list-frame vertical-list"> 196 <div class="list-frame vertical-list">
192 <template is="dom-repeat" items="[[languages.enabled]]"> 197 <template is="dom-repeat" items="[[languages.enabled]]">
193 <div class="list-item"> 198 <div class="list-item">
194 <paper-checkbox 199 <paper-checkbox
195 checked="[[item.spellCheckEnabled]]" 200 checked="[[item.spellCheckEnabled]]"
196 on-change="onSpellCheckChange_" 201 on-change="onSpellCheckChange_"
197 disabled$="[[!item.language.supportsSpellcheck]]"> 202 disabled$="[[!item.language.supportsSpellcheck]]">
198 [[item.language.displayName]] 203 [[item.language.displayName]]
199 </paper-checkbox> 204 </paper-checkbox>
200 </label> 205 </label>
201 </template> 206 </template>
202 <div class="list-item list-button" on-tap="onEditDictionaryTap_"> 207 <div class="list-item">
203 <a is="action-link">$i18n{manageSpellCheck}</a> 208 <a is="action-link" class="list-button"
209 on-tap="onEditDictionaryTap_">
210 $i18n{manageSpellCheck}
211 </a>
204 </div> 212 </div>
205 </div> 213 </div>
206 </iron-collapse> 214 </iron-collapse>
207 </if> 215 </if>
208 <template is="cr-lazy-render" id="menu"> 216 <template is="cr-lazy-render" id="menu">
209 <dialog is="cr-action-menu" 217 <dialog is="cr-action-menu"
210 class$="[[getMenuClass_(prefs.translate.enabled.value)]]"> 218 class$="[[getMenuClass_(prefs.translate.enabled.value)]]">
211 <if expr="chromeos or is_win"> 219 <if expr="chromeos or is_win">
212 <paper-checkbox id="uiLanguageItem" class="dropdown-item" 220 <paper-checkbox id="uiLanguageItem" class="dropdown-item"
213 checked="[[isProspectiveUILanguage_( 221 checked="[[isProspectiveUILanguage_(
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 </if> 284 </if>
277 </settings-animated-pages> 285 </settings-animated-pages>
278 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 286 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
279 <settings-add-languages-dialog languages="{{languages}}" 287 <settings-add-languages-dialog languages="{{languages}}"
280 language-helper="[[languageHelper]]"> 288 language-helper="[[languageHelper]]">
281 </settings-add-languages-dialog> 289 </settings-add-languages-dialog>
282 </template> 290 </template>
283 </template> 291 </template>
284 <script src="languages_page.js"></script> 292 <script src="languages_page.js"></script>
285 </dom-module> 293 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698