Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/resources/settings/internet_page/network_summary_item.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)
Patch Set: add bug link to clarify comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 1 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
2 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_list. html"> 2 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_list. html">
3 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_list_ item.html"> 3 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_list_ item.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> 10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">
11 <link rel="import" href="/settings_shared_css.html"> 11 <link rel="import" href="/settings_shared_css.html">
12 <link rel="import" href="network_siminfo.html"> 12 <link rel="import" href="network_siminfo.html">
13 13
14 <dom-module name="network-summary-item"> 14 <dom-module name="network-summary-item">
15 <template> 15 <template>
16 <style include="settings-shared"> 16 <style include="settings-shared">
17 paper-spinner { 17 paper-spinner {
18 @apply(--cr-icon-height-width); 18 @apply(--cr-icon-height-width);
19 margin: 0 var(--settings-box-row-padding); 19 margin: 0 var(--settings-box-row-padding);
20 } 20 }
21 21
22 network-siminfo { 22 network-siminfo {
23 padding: 0 var(--settings-box-row-padding); 23 padding: 0 var(--settings-box-row-padding);
24 } 24 }
25 25
26 .button-row {
27 align-items: center;
28 display: flex;
29 min-height: var(--settings-row-min-height);
30 }
31
32 .padded { 26 .padded {
33 @apply(--settings-list-frame-padding); 27 @apply(--settings-list-frame-padding);
34 } 28 }
35 29
36 #buttons { 30 #buttons {
37 align-items: center; 31 align-items: center;
38 } 32 }
39 33
40 #details { 34 #details {
41 align-items: center; 35 align-items: center;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 <template is="dom-if" 96 <template is="dom-if"
103 if="[[networksDomIfIsTrue_(expanded_, wasExpanded_)]]"> 97 if="[[networksDomIfIsTrue_(expanded_, wasExpanded_)]]">
104 <iron-collapse 98 <iron-collapse
105 opened="[[networksIronCollapseIsOpened_(expanded_, wasExpanded_)]]"> 99 opened="[[networksIronCollapseIsOpened_(expanded_, wasExpanded_)]]">
106 <div class="layout vertical padded"> 100 <div class="layout vertical padded">
107 <cr-network-list id="networkList" networks="[[networkStateList]]" 101 <cr-network-list id="networkList" networks="[[networkStateList]]"
108 show-buttons> 102 show-buttons>
109 </cr-network-list> 103 </cr-network-list>
110 <template is="dom-if" 104 <template is="dom-if"
111 if="[[knownNetworksIsVisible_(activeNetworkState)]]"> 105 if="[[knownNetworksIsVisible_(activeNetworkState)]]">
112 <div class="button-row" actionable on-tap="onKnownNetworksTap_"> 106 <div class="list-item">
113 <a is="action-link">$i18n{knownNetworksButton}</a> 107 <a is="action-link" class="list-button"
Dan Beam 2017/01/23 20:40:09 where is the import that defines action link?
scottchen 2017/01/23 23:08:37 It's just inside settings_shared_css.html currentl
108 on-tap="onKnownNetworksTap_">
109 $i18n{knownNetworksButton}
110 </a>
114 </div> 111 </div>
115 </template> 112 </template>
116 </div> 113 </div>
117 </iron-collapse> 114 </iron-collapse>
118 </template> 115 </template>
119 </template> 116 </template>
120 <script src="network_summary_item.js"></script> 117 <script src="network_summary_item.js"></script>
121 </dom-module> 118 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698