Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2639373002: MD Settings: clean up text controls (links, buttons) (Closed)
Patch Set: move action_link specific stuff to resources/html/action_link_css.html Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html">
2 <link rel="import" href="chrome://resources/html/cr.html"> 3 <link rel="import" href="chrome://resources/html/cr.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 5 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
5 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" > 6 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" >
6 <link rel="import" href="/search_engines_page/search_engine_dialog.html"> 7 <link rel="import" href="/search_engines_page/search_engine_dialog.html">
7 <link rel="import" href="/search_engines_page/search_engines_list.html"> 8 <link rel="import" href="/search_engines_page/search_engines_list.html">
8 <link rel="import" href="/search_engines_page/omnibox_extension_entry.html"> 9 <link rel="import" href="/search_engines_page/omnibox_extension_entry.html">
9 <link rel="import" href="/settings_shared_css.html"> 10 <link rel="import" href="/settings_shared_css.html">
10 11
11 <dom-module id="settings-search-engines-page"> 12 <dom-module id="settings-search-engines-page">
12 <link rel="import" type="css" href="chrome://resources/css/action_link.css">
13 <template> 13 <template>
14 <style include="settings-shared"> 14 <style include="settings-shared action-link">
15 .extension-engines { 15 .extension-engines {
16 @apply(--settings-list-frame-padding); 16 @apply(--settings-list-frame-padding);
17 } 17 }
18 18
19 settings-omnibox-extension-entry { 19 settings-omnibox-extension-entry {
20 border-top: var(--settings-separator-line); 20 border-top: var(--settings-separator-line);
21 } 21 }
22 22
23 settings-omnibox-extension-entry:first-of-type { 23 settings-omnibox-extension-entry:first-of-type {
24 border-top: none; 24 border-top: none;
25 } 25 }
26 </style> 26 </style>
27 <div class="settings-box first"> 27 <div class="settings-box first">
28 <h2>$i18n{searchEnginesDefault}</h2> 28 <h2>$i18n{searchEnginesDefault}</h2>
29 </div> 29 </div>
30 <settings-search-engines-list engines="[[defaultEngines]]"> 30 <settings-search-engines-list engines="[[defaultEngines]]">
31 </settings-search-engines-list> 31 </settings-search-engines-list>
32 <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp> 32 <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
33 <settings-search-engine-dialog></settings-search-engine-dialog> 33 <settings-search-engine-dialog></settings-search-engine-dialog>
34 </template> 34 </template>
35 <div class="settings-box first"> 35 <div class="settings-box first">
36 <h2>$i18n{searchEnginesOther}</h2> 36 <h2>$i18n{searchEnginesOther}</h2>
37 </div> 37 </div>
38 <!-- TODO(dbeam): why does on-click work with keyboard but on-tap 38 <!-- TODO(dbeam): why does on-click work with keyboard but on-tap
39 doesn't? --> 39 doesn't? -->
40 <settings-search-engines-list engines="[[otherEngines]]"> 40 <settings-search-engines-list engines="[[otherEngines]]">
41 <a class="list-item list-button" is="action-link" 41 <div class="list-item" id="addSearchEngine">
42 on-tap="onAddSearchEngineTap_" id="addSearchEngine"> 42 <a is="action-link" class="list-button" on-tap="onAddSearchEngineTap_">
43 $i18n{searchEnginesAddSearchEngine}</a> 43 $i18n{searchEnginesAddSearchEngine}
44 </a>
45 </div>
44 </settings-search-engines-list> 46 </settings-search-engines-list>
45 47
46 <template is="dom-if" if="[[showExtensionsList_]]"> 48 <template is="dom-if" if="[[showExtensionsList_]]">
47 <div class="settings-box first"> 49 <div class="settings-box first">
48 <h2>$i18n{searchEnginesExtension}</h2> 50 <h2>$i18n{searchEnginesExtension}</h2>
49 </div> 51 </div>
50 <iron-list id="extensions" class="extension-engines" selectable 52 <iron-list id="extensions" class="extension-engines" selectable
51 items="[[extensions]]"> 53 items="[[extensions]]">
52 <template> 54 <template>
53 <settings-omnibox-extension-entry engine="[[item]]" 55 <settings-omnibox-extension-entry engine="[[item]]"
54 tabindex$="[[tabIndex]]"> 56 tabindex$="[[tabIndex]]">
55 </settings-omnibox-extension-entry> 57 </settings-omnibox-extension-entry>
56 </template> 58 </template>
57 </iron-list> 59 </iron-list>
58 </template> 60 </template>
59 </template> 61 </template>
60 <script src="search_engines_page.js"></script> 62 <script src="search_engines_page.js"></script>
61 </dom-module> 63 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698