Issue 263933002: Introduce a microtask suppression scope and move microtask methods to isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263933002: Introduce a microtask suppression scope and move microtask methods to isolate (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
adamk

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce a microtask suppression scope and move microtask methods to isolate BUG=369503 R=adamk@chromium.org LOG=y TEST=cctest/test-api/SetAutorunMicrotasks Committed: https://code.google.com/p/v8/source/detail?r=21128

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -56 lines)			Patch
M	include/v8.h	View	1	3 chunks	+40 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1	3 chunks	+34 lines, -7 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/v8.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/v8.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	test/cctest/test-api.cc	View		7 chunks	+43 lines, -30 lines	0 comments	Download
M	test/cctest/test-microtask-delivery.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm with type nit (no need for a void*) https://codereview.chromium.org/263933002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/263933002/diff/1/include/v8.h#newcode4125 include/v8.h:4125: ...

6 years, 7 months ago (2014-05-02 19:16:53 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-05-02 19:31:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21128 (presubmit successful).

Expand Messages | Collapse Messages