Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2639323002: Add missing AST support for covariant keyword and fix bug from previous CL (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing AST support for covariant keyword and fix bug from previous CL R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dac33b0b3dcd4de5b23870ba73e78323d96c0412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 5 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-18 17:38:18 UTC) #2
scheglov
lgtm
3 years, 11 months ago (2017-01-18 17:40:45 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-18 17:41:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dac33b0b3dcd4de5b23870ba73e78323d96c0412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698