Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2639273004: Use entities in main_call_stub_generator (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 3 chunks +8 lines, -10 lines 1 comment Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-19 15:31:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2639273004/diff/1/pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart File pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart (left): https://codereview.chromium.org/2639273004/diff/1/pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart#oldcode9 pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart:9: import '../compiler.dart' show Compiler; yay!
3 years, 11 months ago (2017-01-19 16:49:17 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-20 08:33:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c75f2f009becfe6f25505688ff0a0abfe771e1b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698