Issue 2639273003: Fix environment mismatch in AOT inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2639273003: Fix environment mismatch in AOT inlining. (Closed)

Created:
3 years, 11 months ago by Florian Schneider

Modified:
3 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix environment mismatch in AOT inlining. When replacing _instanceOf with a cid range check, the number of arguments passed as arguments changes. The new environment must reflect this change. The failing test is from #28431, but the bug itself has nothing to do with checked mode. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d8f223560aa60fcb6dfd648d58fc9b7614a3c2eb

Patch Set 1 #

Patch Set 2 : clean up #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

3 years, 11 months ago (2017-01-19 18:25:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d8f223560aa60fcb6dfd648d58fc9b7614a3c2eb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages