Issue 2639253003: Handle constructor bodies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2639253003: Handle constructor bodies (Closed)

Created:
3 years, 11 months ago by karlklose

Modified:
3 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Handle constructor bodies Also rewrites untransformed closures (for example those in initializers) to throw an exception. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/e88a478a7c23af4002aa9f6148f03a731385961f

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -43 lines)			Patch
M	pkg/kernel/lib/transformations/closure/converter.dart	View	7 chunks	+68 lines, -42 lines	0 comments	Download
A	pkg/kernel/lib/transformations/closure/invalidate_closures.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	pkg/kernel/lib/transformations/closure_conversion.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

karlklose

Committed patchset #1 (id:1) manually as e88a478a7c23af4002aa9f6148f03a731385961f (presubmit successful).

3 years, 11 months ago (2017-01-19 12:32:27 UTC) #4

karlklose

3 years, 11 months ago (2017-01-19 13:10:38 UTC) #6

Message was sent while issue was closed.

On 2017/01/19 12:35:39, ahe wrote:
> Did you forget adding tests?

Yes - I was only looking at running language tests for this.