Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 263923004: Next bunch of fixes for check elimination. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Next bunch of fixes for check elimination. - Canonicalize HCheckMapValue with constant map to HCheckMaps, and get rid of the special treatment during check elimination. - Track only stable object maps for HConstants and add CHECK()s to verify state during code generation. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -87 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 4 chunks +2 lines, -43 lines 0 comments Download
M src/hydrogen-instructions.h View 7 chunks +58 lines, -14 lines 0 comments Download
M src/hydrogen-instructions.cc View 12 chunks +38 lines, -14 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-06 06:26:02 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-06 06:34:11 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-06 07:05:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698