Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ui/views/view.h

Issue 2639203007: Update SetPaintToLayer to accept LayerType (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view.h
diff --git a/ui/views/view.h b/ui/views/view.h
index 147785c6a86b255dc5e279a35c33d7bb0b7aa76b..1db5659551f08e4a65162922f8ce556b129e6d74 100644
--- a/ui/views/view.h
+++ b/ui/views/view.h
@@ -334,10 +334,14 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// Sets whether this view paints to a layer. A view paints to a layer if
// either of the following are true:
// . the view has a non-identity transform.
- // . SetPaintToLayer(true) has been invoked.
+ // . SetPaintToLayer(ui::LayerType) has been invoked.
// View creates the Layer only when it exists in a Widget with a non-NULL
// Compositor.
- void SetPaintToLayer(bool paint_to_layer);
+ void SetPaintToLayer(ui::LayerType layer_type = ui::LAYER_TEXTURED);
+
+ // Destroys the layer associated with this view, and reparents any descendants
+ // to the destroyed layer's parent.
sky 2017/01/23 21:21:05 Document this has no effect if the view does not c
yiyix 2017/01/24 03:14:53 Thanks, it is good to include in the description.
+ void DestroyLayer();
// Overridden from ui::LayerOwner:
std::unique_ptr<ui::Layer> RecreateLayer() override;
@@ -1369,7 +1373,7 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// Accelerated painting ------------------------------------------------------
// Creates the layer and related fields for this view.
- void CreateLayer();
+ void CreateLayer(ui::LayerType layer_type);
// Recursively calls UpdateParentLayers() on all descendants, stopping at any
// Views that have layers. Calls UpdateParentLayer() for any Views that have
@@ -1392,10 +1396,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// this subtree.
void OrphanLayers();
- // Destroys the layer associated with this view, and reparents any descendants
- // to the destroyed layer's parent.
- void DestroyLayer();
-
// Input ---------------------------------------------------------------------
bool ProcessMousePressed(const ui::MouseEvent& event);
« no previous file with comments | « ui/views/controls/slide_out_view.cc ('k') | ui/views/view.cc » ('j') | ui/views/view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698