Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: Fixed test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index 731b2dcb5f7822fd866edea7c86642f3390e56d0..d75ed80d39c0dccb1a6d8ff8efe265cca0310f4f 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -896,6 +896,12 @@
{ "name": "displayedInsecureContentStyle", "$ref": "SecurityState", "description": "Security state representing a page that displayed insecure content." }
],
"description": "Information about insecure content on the page."
+ },
+ {
+ "id": "CertificateErrorAction",
+ "type": "string",
+ "enum": ["continue", "cancel", "deny"],
+ "description": "The action to take when a certificate error occurs. continue will continue processing the request, cancel will cancel the request using net::ERR_ANORTED and deny will deny the request using net::ERR_INSECURE_RESPONSE."
Sami 2017/02/08 14:58:43 typo: ERR_ABORTED
pfeldman 2017/02/08 18:24:00 For better or worse, we don't use internal terms w
irisu 2017/02/14 05:46:14 Removed.
}
],
"commands": [
@@ -910,6 +916,18 @@
{
"name": "showCertificateViewer",
"description": "Displays native dialog with the certificate details."
+ },
+ {
+ "name": "handleCertificateError",
+ "description": "Handles a certificate error.",
+ "parameters": [
+ { "name": "eventID", "type": "integer", "description": "The ID of the event."},
+ { "name": "action", "$ref": "CertificateErrorAction", "description": "The action to take on the certificate error." }
+ ]
+ },
+ {
+ "name": "enableCertificateErrorHandling",
+ "description": "Enables tracking certificate errors."
}
],
"events": [
@@ -923,6 +941,13 @@
{ "name": "insecureContentStatus", "$ref": "InsecureContentStatus", "description": "Information about insecure content on the page." },
{ "name": "summary", "type": "string", "description": "Overrides user-visible description of the state.", "optional": true }
]
+ },
+ {
+ "name": "certificateError",
+ "description": "There is a certificate error.",
+ "parameters": [
+ { "name": "eventID", "type": "integer", "description": "The ID of the event."}
pfeldman 2017/02/08 18:24:00 It is unlikely that I can make a decision programm
Eric Seckler 2017/02/08 18:53:10 Let's add some more information from the SSLManage
irisu 2017/02/14 05:46:14 Added extra parameters. Any more parameters you'd
Eric Seckler 2017/02/14 18:42:24 I'd be great to include some info about the certif
irisu 2017/02/16 00:24:30 SSLInfo has a lot of fields we could add, but I'm
+ ]
}
]
},

Powered by Google App Engine
This is Rietveld 408576698