Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: Fixed test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 74218f22e802ac54244c7f3ca99d489e54964093..286d15213c25b5a3f3aa87d45ad98178d4e8bc45 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -12,8 +12,10 @@
#include "base/process/kill.h"
#include "base/process/process_handle.h"
#include "content/common/content_export.h"
+#include "content/public/browser/certificate_request_result_type.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/reload_type.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/common/frame_navigate_params.h"
#include "content/public/common/resource_type.h"
#include "ipc/ipc_listener.h"
@@ -298,6 +300,11 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// This method is invoked when the visible security state of the page changes.
virtual void DidChangeVisibleSecurityState() {}
+ using CertErrorCallback = WebContents::CertErrorCallback;
pfeldman 2017/02/08 18:24:00 The code you change is all within content/, so you
+ // This method is invoked when there is an internal certificate error.
+ // Return value indicates that this observer will handle the error.
+ virtual bool NotifyCertificateError(CertErrorCallback callback);
+
// This method is invoked when content was loaded from an in-memory cache.
virtual void DidLoadResourceFromMemoryCache(
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698