Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: content/browser/devtools/protocol/security_handler.h

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: Add certificate error command tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/security_handler.h
diff --git a/content/browser/devtools/protocol/security_handler.h b/content/browser/devtools/protocol/security_handler.h
index 2d32c687a40374a5df7980595827ee2711f067d6..26ca354fa5291e8d79af6d8e02067cf5310a32fe 100644
--- a/content/browser/devtools/protocol/security_handler.h
+++ b/content/browser/devtools/protocol/security_handler.h
@@ -5,9 +5,12 @@
#ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
#define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
+#include <unordered_map>
+
#include "base/macros.h"
#include "content/browser/devtools/protocol/devtools_domain_handler.h"
#include "content/browser/devtools/protocol/security.h"
+#include "content/public/browser/certificate_request_result_type.h"
#include "content/public/browser/web_contents_observer.h"
namespace content {
@@ -29,16 +32,24 @@ class SecurityHandler : public DevToolsDomainHandler,
Response Enable() override;
Response Disable() override;
Response ShowCertificateViewer() override;
+ Response HandleCertificateError(int event_id, const String& action) override;
+ Response EnableCertificateErrorHandling() override;
private:
void AttachToRenderFrameHost();
+ using CertErrorCallbackMap = std::unordered_map<int, CertErrorCallback>;
+
// WebContentsObserver overrides
void DidChangeVisibleSecurityState() override;
+ bool NotifyCertificateError(CertErrorCallback) override;
std::unique_ptr<Security::Frontend> frontend_;
bool enabled_;
RenderFrameHostImpl* host_;
+ int last_cert_error_id_;
+ CertErrorCallbackMap callbacks_;
+ bool certificate_error_enabled_;
DISALLOW_COPY_AND_ASSIGN(SecurityHandler);
};

Powered by Google App Engine
This is Rietveld 408576698