Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 8adb92cddeaac18195f75ae7a18dbfe43bf4f194..5e6005198755b2c3e6ff54e923ddc7b8d4938b24 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2288,12 +2288,13 @@ void ChromeContentBrowserClient::AllowCertificateError(
callback) {
DCHECK(web_contents);
if (resource_type != content::RESOURCE_TYPE_MAIN_FRAME) {
- // A sub-resource has a certificate error. The user doesn't really
+ // A sub-resource has a certificate error. The user doesn't really
// have a context for making the right decision, so block the
// request hard, without an info bar to allow showing the insecure
// content.
- if (!callback.is_null())
+ if (!callback.is_null()) {
irisu 2017/03/06 11:56:49 Ignore brackets. (Will fix when back on workstatio
callback.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY);
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698