Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 74218f22e802ac54244c7f3ca99d489e54964093..9033767bf997efd05eed95fa77212303f020f513 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -12,6 +12,7 @@
#include "base/process/kill.h"
#include "base/process/process_handle.h"
#include "content/common/content_export.h"
+#include "content/public/browser/certificate_request_result_type.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/reload_type.h"
#include "content/public/common/frame_navigate_params.h"
@@ -298,6 +299,11 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// This method is invoked when the visible security state of the page changes.
virtual void DidChangeVisibleSecurityState() {}
+ using CertErrorHandler =
Eric Seckler 2017/01/19 11:42:28 nit: using CertErrorHandler = WebContents::CertErr
irisu 2017/02/07 23:30:19 Done.
+ base::Callback<void(content::CertificateRequestResultType)>;
+ // This method is invoked when there is an internal certificate error.
Eric Seckler 2017/01/19 11:42:28 nit: mention what return value indicates :)
irisu 2017/02/07 23:30:19 Done.
+ virtual bool NotifyCertificateError(CertErrorHandler callback);
+
// This method is invoked when content was loaded from an in-memory cache.
virtual void DidLoadResourceFromMemoryCache(
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698