Add certificate error handling to devtools.

content/browser/devtools/protocol/security_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/security_handler.h"
 
 #include <string>
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/public/browser/navigation_controller.h"
@@ skipping 41 matching lines @@
         .SetHasCertificate(it.has_certificate)
         .Build());
   }
 }
 
 }  // namespace
 
 SecurityHandler::SecurityHandler()
     : DevToolsDomainHandler(Security::Metainfo::domainName),
       enabled_(false),
-      host_(nullptr) {
-}
+      host_(nullptr),
+      last_cert_error_id_(0),
+      certificate_error_enabled_(false) {}
 
 SecurityHandler::~SecurityHandler() {
 }
 
 void SecurityHandler::Wire(UberDispatcher* dispatcher) {
   frontend_.reset(new Security::Frontend(dispatcher->channel()));
   Security::Dispatcher::wire(dispatcher, this);
 }
 
 void SecurityHandler::AttachToRenderFrameHost() {
@@ skipping 55 matching lines @@
           .Build();
 
   frontend_->SecurityStateChanged(
       security_state,
       security_style_explanations.scheme_is_cryptographic,
       std::move(explanations),
       std::move(insecure_status),
       Maybe<std::string>(security_style_explanations.summary));
 }
 
+bool SecurityHandler::NotifyCertificateError(CertErrorCallback handler) {
+  if (!certificate_error_enabled_)
+    return false;
+  callbacks_[++last_cert_error_id_] = handler;
+  frontend_->CertificateError(last_cert_error_id_);

[pfeldman, 2017/02/08 18:24:00]

You should report certificate errors whenever Security domain is enabled. Store
handler conditionally instead.

[irisu, 2017/02/14 05:46:14]

Done.

+  return true;
+}
+
 Response SecurityHandler::Enable() {
   enabled_ = true;
   if (host_)
     AttachToRenderFrameHost();
 
   return Response::OK();
 }
 
 Response SecurityHandler::Disable() {

[pfeldman, 2017/02/08 18:24:00]

You should release all the handlers here with default values.

[irisu, 2017/02/14 05:46:14]

Done.

   enabled_ = false;
   WebContentsObserver::Observe(nullptr);
   return Response::OK();
 }
 
 Response SecurityHandler::ShowCertificateViewer() {
   if (!host_)
     return Response::InternalError();
   WebContents* web_contents = WebContents::FromRenderFrameHost(host_);
   scoped_refptr<net::X509Certificate> certificate =
       web_contents->GetController().GetVisibleEntry()->GetSSL().certificate;
   if (!certificate)
     return Response::Error("Could not find certificate");
   web_contents->GetDelegate()->ShowCertificateViewerInDevTools(
       web_contents, certificate);
   return Response::OK();
 }
 
+Response SecurityHandler::HandleCertificateError(int event_id,
+                                                 const String& action) {
+  content::CertificateRequestResultType type =
+      content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY;
+  Response response = Response::OK();
+  if (action == "continue") {
+    type = content::CERTIFICATE_REQUEST_RESULT_TYPE_CONTINUE;
+  } else if (action == "cancel") {
+    type = content::CERTIFICATE_REQUEST_RESULT_TYPE_CANCEL;
+  } else if (action == "deny") {
+    type = content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY;
+  } else {
+    response =
+        Response::Error(String("Unknown Certificate Error Action: " + action));
+  }
+  if (callbacks_.find(event_id) == callbacks_.end())

[Sami, 2017/02/08 14:58:43]

nit: add {} please

[irisu, 2017/02/14 05:46:14]

Done.

+    return Response::Error(
+        String("Unknown event id: " + std::to_string(event_id)));
+  callbacks_[event_id].Run(type);
+  callbacks_.erase(event_id);
+  return response;
+}
+
+Response SecurityHandler::EnableCertificateErrorHandling() {
+  certificate_error_enabled_ = true;
+  if (!enabled_) {

[Sami, 2017/02/08 14:58:43]

I think we should just require the user to also call Enable() instead doing it
for them.

[pfeldman, 2017/02/08 18:24:00]

+1, you also need to provide a way to disable it. setOverrideCertificateErrors

[irisu, 2017/02/14 05:46:14]

Done.

+    enabled_ = true;
+    if (host_)
+      AttachToRenderFrameHost();
+  }
+  return Response::OK();
+}
+
 }  // namespace protocol
 }  // namespace content