Add certificate error handling to devtools.

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 1390 matching lines @@
       web_contents->GetController().GetTransientEntry();
   ASSERT_TRUE(transient_entry);
   transient_entry->GetSSL().certificate = expired_cert();
   ASSERT_TRUE(transient_entry->GetSSL().certificate);
 
   std::unique_ptr<base::DictionaryValue> params2(new base::DictionaryValue());
   SendCommand("Security.showCertificateViewer", std::move(params2), true);
   EXPECT_EQ(transient_entry->GetSSL().certificate, last_shown_certificate());
 }
 
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, CertificateError) {
+  net::EmbeddedTestServer https_server(net::EmbeddedTestServer::TYPE_HTTPS);
+  https_server.SetSSLConfig(net::EmbeddedTestServer::CERT_EXPIRED);
+  ASSERT_TRUE(https_server.Start());
+  GURL test_url = https_server.GetURL("/devtools/image.html");
+  std::unique_ptr<base::DictionaryValue> params;
+  std::unique_ptr<base::DictionaryValue> command_params;
+  int eventID;
+
+  shell()->LoadURL(GURL("about://blank"));
+  WaitForLoadStop(shell()->web_contents());
+
+  Attach();
+  SendCommand("Network.enable", nullptr, true);
+  SendCommand("Security.enable", nullptr, false);
+  command_params.reset(new base::DictionaryValue());
+  command_params->SetBoolean("override", true);
+  SendCommand("Security.setOverrideCertificateErrors",
+              std::move(command_params), true);
+
+  // Test cancel.
+  SendCommand("Network.clearBrowserCache", nullptr, true);
+  SendCommand("Network.clearBrowserCookies", nullptr, true);
+  shell()->LoadURL(test_url);
+  params = WaitForNotification("Security.certificateError", false);
+  EXPECT_TRUE(params->GetInteger("eventID", &eventID));
+  command_params.reset(new base::DictionaryValue());
+  command_params->SetInteger("eventID", eventID);
+  command_params->SetString("action", "cancel");
+  SendCommand("Security.handleCertificateError", std::move(command_params),

[estark, 2017/03/14 01:22:50]

Hmm, this test doesn't currently check that the command is actually handled
correctly, IIUC.

It seems to me that the expected state is that a navigation is in progress
before the handleCertificateError command is sent, and then is stopped. Is that
correct? And if so, is there any way to use TestNavigationObserver to test for
that? I'm imagining something like this (in pseudocode):

TestNavigationObserver cancel_observer;
shell()->LoadUrl(...);
WaitForNotification("Security.certificateError", ...);
EXPECT_EQ(test_url,
shell()->web_contents()->GetController().GetTransientEntry()->GetURL());
...
SendCommand("Security.handleCertificateError"...);
cancel_observer.Wait();
EXPECT_FALSE(shell()->web_contents()->GetController().GetPendingEntry());
EXPECT_EQ(GURL("about://blank"),
shell()->web_contents()->GetController().GetLastCommittedEntry()->GetURL()));

something like that, maybe?

[irisu, 2017/03/16 03:40:18]

Done.

+              false);
+
+  // Test continue.
+  SendCommand("Network.clearBrowserCache", nullptr, true);
+  SendCommand("Network.clearBrowserCookies", nullptr, true);
+  TestNavigationObserver continue_observer(shell()->web_contents(), 1);
+  shell()->LoadURL(test_url);
+  params = WaitForNotification("Security.certificateError", false);
+  EXPECT_TRUE(params->GetInteger("eventID", &eventID));
+  command_params.reset(new base::DictionaryValue());
+  command_params->SetInteger("eventID", eventID);
+  command_params->SetString("action", "continue");
+  SendCommand("Security.handleCertificateError", std::move(command_params),
+              false);
+  WaitForNotification("Network.loadingFinished", true);
+  continue_observer.Wait();

[estark, 2017/03/14 01:22:50]

Maybe add an expectation that you ended up on the expected page?

[irisu, 2017/03/16 03:40:18]

Done.

+}
+
 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
   std::string temp;
   std::set<std::string> ids;
   std::unique_ptr<base::DictionaryValue> command_params;
   std::unique_ptr<base::DictionaryValue> params;
 
   ASSERT_TRUE(embedded_test_server()->Start());
   GURL first_url = embedded_test_server()->GetURL("/devtools/navigation.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), first_url, 1);
 
@@ skipping 220 matching lines @@
       EXPECT_EQ("polyglottal", value);
       found++;
     } else {
       FAIL();
     }
   }
   EXPECT_EQ(2u, found);
 }
 
 }  // namespace content