Add certificate error handling to devtools.

content/browser/devtools/protocol/security_handler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
 
+#include <unordered_map>
+
 #include "base/macros.h"
 #include "content/browser/devtools/protocol/devtools_domain_handler.h"
 #include "content/browser/devtools/protocol/security.h"
+#include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/web_contents_observer.h"
 
 namespace content {
 
 class DevToolsAgentHostImpl;
 class RenderFrameHostImpl;
 
 namespace protocol {
 
 class SecurityHandler : public DevToolsDomainHandler,
                         public Security::Backend,
                         public WebContentsObserver {
  public:
   SecurityHandler();
   ~SecurityHandler() override;
 
   void Wire(UberDispatcher* dispatcher) override;
   void SetRenderFrameHost(RenderFrameHostImpl* host) override;
 
   static SecurityHandler* FromAgentHost(DevToolsAgentHostImpl* host);
 
   Response Enable() override;

[estark, 2017/02/28 23:34:01]

optional nit: while you're here, if you wouldn't mind adding "//
Security::Backend overrides" here and "// DevToolsDomainHandler overrides" above
line 30, that would be very much appreciated!

[irisu, 2017/03/06 11:56:49]

Done.

   Response Disable() override;
   Response ShowCertificateViewer() override;
+  Response HandleCertificateError(int event_id, const String& action) override;
+  Response SetOverrideCertificateErrors(bool override) override;
+
+  using CertErrorCallback =

[estark, 2017/02/28 23:34:01]

per
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...,
this should be at the top of the 'public:' section

[irisu, 2017/03/06 11:56:49]

Done.

+      base::Callback<void(content::CertificateRequestResultType)>;
+  using CertErrorCallbackMap = std::unordered_map<int, CertErrorCallback>;

[estark, 2017/02/28 23:34:01]

this one could be private, right?

[irisu, 2017/03/06 11:56:49]

Done.

+
+  bool NotifyCertificateError(int cert_error,

[estark, 2017/02/28 23:34:01]

Please document (especially what the return value means)

[irisu, 2017/03/06 11:56:48]

Done.

+                              const GURL& request_url,
+                              CertErrorCallback callback);
 
  private:
   void AttachToRenderFrameHost();
+  void FlushPendingRequests();

[estark, 2017/02/28 23:34:01]

nit: maybe FlushPendingCertificateErrorNotifications? That's kinda long I guess.
But it's unclear from the current name that this is specific to certificate
errors.

[irisu, 2017/03/06 11:56:49]

Done.

 
   // WebContentsObserver overrides
   void DidChangeVisibleSecurityState() override;
+  void DidFinishNavigation(NavigationHandle* navigation_handle) override;
 
   std::unique_ptr<Security::Frontend> frontend_;
   bool enabled_;
   RenderFrameHostImpl* host_;
+  int last_cert_error_id_ = 0;
+  CertErrorCallbackMap callbacks_;
+  bool certificate_errors_overriden_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityHandler);
 };
 
 }  // namespace protocol
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_