Add certificate error handling to devtools.

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 
 #include "base/callback_forward.h"
 #include "base/files/file_path.h"
 #include "base/process/kill.h"
 #include "base/strings/string16.h"
 #include "base/supports_user_data.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
+#include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/save_page_type.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/stop_find_action.h"
 #include "ipc/ipc_sender.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/window_open_disposition.h"
@@ skipping 395 matching lines @@
 
   // Attaches this inner WebContents to its container frame
   // |outer_contents_frame| in |outer_web_contents|.
   virtual void AttachToOuterWebContentsFrame(
       WebContents* outer_web_contents,
       RenderFrameHost* outer_contents_frame) = 0;
 
   // Invoked when visible security state changes.
   virtual void DidChangeVisibleSecurityState() = 0;
 
+  using CertErrorHandler =

[Eric Seckler, 2017/01/19 11:42:28]

nit: maybe CertErrorCallback is more descriptive of what this is?

[irisu, 2017/02/07 23:30:19]

Done.

+      base::Callback<void(content::CertificateRequestResultType)>;
+  // Invoked when a certificate error occurs.

[Eric Seckler, 2017/01/19 11:42:28]

nit: mention in comment that this is to give observers a chance to handle the
error and that return value indicates whether the certificate error will be
handled by one of the observers.

[irisu, 2017/02/07 23:30:19]

Done.

+  virtual bool NotifyCertificateError(CertErrorHandler handler);

[Eric Seckler, 2017/01/19 11:42:28]

nit: how about making this pure-virtual, i.e.
virtual bool NotifyCertificateError(CertErrorHandler handler) = 0;

[irisu, 2017/02/07 23:30:19]

Done.

+
   // Commands ------------------------------------------------------------------
 
   // Stop any pending navigation.
   virtual void Stop() = 0;
 
   // Creates a new WebContents with the same state as this one. The returned
   // heap-allocated pointer is owned by the caller.
   virtual WebContents* Clone() = 0;
 
   // Reloads the focused frame.
@@ skipping 320 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_