Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/search_engines/template_url.cc

Issue 2639153002: Make extensions DSE persistent in browser prefs (Reland) (Closed)
Patch Set: Fixed flakiness caused by extension reload while TemplateURLService is not loaded Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url.cc
diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc
index 8e300bd547ff6373b62acc6bf3a93e5e461f1441..f0d07ac76513a148d45737896616a19810ea84ca 100644
--- a/components/search_engines/template_url.cc
+++ b/components/search_engines/template_url.cc
@@ -165,22 +165,6 @@ bool IsTemplateParameterString(const std::string& param) {
(*(param.rbegin()) == kEndParameter);
}
-// Special case for search_terms_replacement_key comparison, because of
-// its special initialization in TemplateUrl constructor.
-bool SearchTermsReplacementKeysMatch(
- const std::string& search_terms_replacement_key1,
- const std::string& search_terms_replacement_key2) {
- if (search_terms_replacement_key1 == search_terms_replacement_key2)
- return true;
- if (search_terms_replacement_key1 == google_util::kInstantExtendedAPIParam &&
- search_terms_replacement_key2 == kGoogleInstantExtendedEnabledKeyFull)
- return true;
- if (search_terms_replacement_key2 == google_util::kInstantExtendedAPIParam &&
- search_terms_replacement_key1 == kGoogleInstantExtendedEnabledKeyFull)
- return true;
- return false;
-}
-
} // namespace
@@ -1245,6 +1229,19 @@ bool TemplateURL::MatchesData(const TemplateURL* t_url,
data->search_terms_replacement_key);
}
+// static
+bool TemplateURL::SearchTermsReplacementKeysMatch(
+ const std::string& search_terms_replacement_key1,
+ const std::string& search_terms_replacement_key2) {
+ if (search_terms_replacement_key1 == google_util::kInstantExtendedAPIParam &&
+ search_terms_replacement_key2 == kGoogleInstantExtendedEnabledKeyFull)
+ return true;
+ if (search_terms_replacement_key2 == google_util::kInstantExtendedAPIParam &&
+ search_terms_replacement_key1 == kGoogleInstantExtendedEnabledKeyFull)
+ return true;
+ return search_terms_replacement_key1 == search_terms_replacement_key2;
+}
+
base::string16 TemplateURL::AdjustedShortNameForLocaleDirection() const {
base::string16 bidi_safe_short_name = data_.short_name();
base::i18n::AdjustStringForLocaleDirection(&bidi_safe_short_name);

Powered by Google App Engine
This is Rietveld 408576698