Gardening: Fix standalone/io/process_start_exception_test.dart.

Gardening: Fix standalone/io/process_start_exception_test.dart.

It assumed that an attempt to start a non-existent binary on POSIX always
results in ENOENT (2). However this is not true: we are using execvp(...)
which attempts to find binaries through PATH (as long as the given filename
does not contain `/`) if binary is not found anywhere in the PATH and
some folder in PATH is inaccessible then execvp(...) fails with EACCES (13).

This caused the test to fail on Android whenever PATH contained /sbin which
is inaccessible.

We fix the test by clearing PATH for child processes.

Fixes issue https://github.com/dart-lang/sdk/issues/28299

R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28299

Committed: https://github.com/dart-lang/sdk/commit/5143f12685530a8c620fa94d6ce52b22ba2b2773

[kustermann, 2017-01-18 11:29:35]

LGTM - nice catch!

[Vyacheslav Egorov (Google), 2017-01-18 12:23:35]

Description was changed from

==========
Gardening: Fix standalone/io/process_start_exception_test.dart.

It assumed that an attempt to start a non-existent binary on POSIX always
results in ENOENT (2). However this is not true: we are using execvp(...)
which attempts to find binaries through PATH (as long as the given filename
does not contain `/`) if binary is not found anywhere in the PATH and
some folder in PATH is inaccessible then execvp(...) fails with EACCES (13).

This caused the test to fail on Android whenever PATH contained /sbin which
is inaccessible.

We fix the test by clearing PATH for child processes.

Fixes issue https://github.com/dart-lang/sdk/issues/28299

R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28299
==========

to

==========
Gardening: Fix standalone/io/process_start_exception_test.dart.

It assumed that an attempt to start a non-existent binary on POSIX always
results in ENOENT (2). However this is not true: we are using execvp(...)
which attempts to find binaries through PATH (as long as the given filename
does not contain `/`) if binary is not found anywhere in the PATH and
some folder in PATH is inaccessible then execvp(...) fails with EACCES (13).

This caused the test to fail on Android whenever PATH contained /sbin which
is inaccessible.

We fix the test by clearing PATH for child processes.

Fixes issue https://github.com/dart-lang/sdk/issues/28299

R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28299

Committed:
https://github.com/dart-lang/sdk/commit/5143f12685530a8c620fa94d6ce52b22ba2b2773
==========

[Vyacheslav Egorov (Google), 2017-01-18 12:23:36]

Committed patchset #1 (id:1) manually as
5143f12685530a8c620fa94d6ce52b22ba2b2773 (presubmit successful).