Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 263903008: aw: Fix detach and destroy interaction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index 84449e80ee517ea3b78cda463b2b587709e14b28..315e35491b797150511d6f2b1afb1171bf607b5e 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -385,7 +385,9 @@ public class AwSettings {
mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
@Override
public void run() {
- nativeUpdateInitialPageScaleLocked(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ nativeUpdateInitialPageScaleLocked(mNativeAwSettings);
+ }
}
});
}
@@ -467,7 +469,9 @@ public class AwSettings {
mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
@Override
public void run() {
- nativeUpdateFormDataPreferencesLocked(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ nativeUpdateFormDataPreferencesLocked(mNativeAwSettings);
+ }
}
});
}
@@ -512,7 +516,9 @@ public class AwSettings {
mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
@Override
public void run() {
- nativeUpdateUserAgentLocked(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ nativeUpdateUserAgentLocked(mNativeAwSettings);
+ }
}
});
}
@@ -544,8 +550,10 @@ public class AwSettings {
mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
@Override
public void run() {
- updateWebkitPreferencesOnUiThreadLocked();
- nativeResetScrollAndScaleState(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ updateWebkitPreferencesOnUiThreadLocked();
+ nativeResetScrollAndScaleState(mNativeAwSettings);
+ }
}
});
}
@@ -1481,7 +1489,9 @@ public class AwSettings {
mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
@Override
public void run() {
- nativeUpdateRendererPreferencesLocked(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ nativeUpdateRendererPreferencesLocked(mNativeAwSettings);
+ }
}
});
}
@@ -1539,6 +1549,7 @@ public class AwSettings {
@CalledByNative
private void updateEverything() {
synchronized (mAwSettingsLock) {
+ assert mNativeAwSettings != 0;
nativeUpdateEverythingLocked(mNativeAwSettings);
}
}
@@ -1546,6 +1557,7 @@ public class AwSettings {
@CalledByNative
private void populateWebPreferences(long webPrefsPtr) {
synchronized (mAwSettingsLock) {
+ assert mNativeAwSettings != 0;
nativePopulateWebPreferencesLocked(mNativeAwSettings, webPrefsPtr);
}
}
@@ -1553,7 +1565,9 @@ public class AwSettings {
private void updateWebkitPreferencesOnUiThreadLocked() {
assert mEventHandler.mHandler != null;
ThreadUtils.assertOnUiThread();
- nativeUpdateWebkitPreferencesLocked(mNativeAwSettings);
+ if (mNativeAwSettings != 0) {
+ nativeUpdateWebkitPreferencesLocked(mNativeAwSettings);
+ }
}
private native long nativeInit(long webContentsPtr);

Powered by Google App Engine
This is Rietveld 408576698