Issue 263903006: Reland "Make same-document history navigations commit with the proper type."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263903006: Reland "Make same-document history navigations commit with the proper type." (Closed)

Created:
6 years, 7 months ago by Nate Chapin

Modified:
6 years, 7 months ago

Reviewers:
dglazkov, abarth-chromium

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reland "Make same-document history navigations commit with the proper type." This reverts commit 9f7dd81e9620e67024b43cedffd25a35c5cd2014. There is a quirk in HistoryController where we commit a history navigation immediately upon starting a same-document navigation. If a same-document history navigation is committed with a HistoryCommitType of BackForwardCommit instead of HistoryInertCommit, the commit logic does the right thing and we don't need that quirk. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174110

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -20 lines)			Patch
M	Source/bindings/v8/custom/V8HistoryCustom.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/History.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/History.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1 2	6 chunks	+13 lines, -9 lines	0 comments	Download
M	Source/core/loader/FrameLoaderTypes.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/263903006/40001

6 years, 7 months ago (2014-05-15 22:29:29 UTC) #5

Message was sent while issue was closed.

Change committed as 174110

Expand Messages | Collapse Messages

Issue 263903006: Reland "Make same-document history navigations commit with the proper type." (Closed)

Description

Patch Set 1 #

Patch Set 2 : +fix #

Patch Set 3 : #

Messages