Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 263903004: Add AttachmentUploader interface and fake implementation. (Closed)

Created:
6 years, 7 months ago by maniscalco
Modified:
6 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Add AttachmentUploader interface and fake implementation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268245

Patch Set 1 : #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -11 lines) Patch
M chrome/browser/sync/glue/shared_change_processor.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A sync/api/attachments/attachment_uploader.h View 1 chunk +46 lines, -0 lines 0 comments Download
A + sync/api/attachments/attachment_uploader.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M sync/api/attachments/fake_attachment_service.h View 3 chunks +4 lines, -1 line 0 comments Download
M sync/api/attachments/fake_attachment_service.cc View 2 chunks +11 lines, -3 lines 0 comments Download
A sync/api/attachments/fake_attachment_uploader.h View 1 chunk +30 lines, -0 lines 0 comments Download
A sync/api/attachments/fake_attachment_uploader.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A sync/api/attachments/fake_attachment_uploader_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M sync/sync_api.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
maniscalco
Hi Pavel, would you please review this change?
6 years, 7 months ago (2014-05-02 21:45:53 UTC) #1
pavely
lgtm
6 years, 7 months ago (2014-05-02 23:48:52 UTC) #2
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 7 months ago (2014-05-05 17:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/263903004/140001
6 years, 7 months ago (2014-05-05 17:07:12 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 19:23:10 UTC) #5
Message was sent while issue was closed.
Change committed as 268245

Powered by Google App Engine
This is Rietveld 408576698