Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 263893005: Rename some PPB_VideoDecoder_Dev implementation types. (Closed)

Created:
6 years, 7 months ago by bbudge
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Rename some PPB_VideoDecoder_Dev implementation types. Adds a "_Dev" suffix to some types that would collide with upcoming public VideoDecoder API. BUG=281689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268450

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Justin's comments. #

Patch Set 4 : Rename resource creation API method CreateVideoDecoder (add Dev). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -182 lines) Patch
M content/renderer/pepper/ppb_video_decoder_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/resource_creation_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/resource_creation_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 1 2 3 8 chunks +12 lines, -12 lines 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_video_decoder_shared.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_video_decoder_shared.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +1 line, -1 line 0 comments Download
D ppapi/thunk/ppb_video_decoder_api.h View 1 chunk +0 lines, -34 lines 0 comments Download
A + ppapi/thunk/ppb_video_decoder_dev_api.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ppapi/thunk/ppb_video_decoder_dev_thunk.cc View 1 2 3 6 chunks +10 lines, -10 lines 0 comments Download
D ppapi/thunk/ppb_video_decoder_thunk.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
bbudge
This is intended to be behavior preserving rename of: ppapi::thunk::PPB_VideoDecoder_API and corresponding rename of two ...
6 years, 7 months ago (2014-05-05 22:39:59 UTC) #1
teravest
lgtm https://codereview.chromium.org/263893005/diff/20001/ppapi/thunk/ppb_video_decoder_dev_thunk.cc File ppapi/thunk/ppb_video_decoder_dev_thunk.cc (right): https://codereview.chromium.org/263893005/diff/20001/ppapi/thunk/ppb_video_decoder_dev_thunk.cc#newcode85 ppapi/thunk/ppb_video_decoder_dev_thunk.cc:85: &Destroy}; Is this from clang format?
6 years, 7 months ago (2014-05-05 22:42:25 UTC) #2
Ami GONE FROM CHROMIUM
rslgtm
6 years, 7 months ago (2014-05-05 22:44:19 UTC) #3
bbudge
https://codereview.chromium.org/263893005/diff/20001/ppapi/thunk/ppb_video_decoder_dev_thunk.cc File ppapi/thunk/ppb_video_decoder_dev_thunk.cc (right): https://codereview.chromium.org/263893005/diff/20001/ppapi/thunk/ppb_video_decoder_dev_thunk.cc#newcode85 ppapi/thunk/ppb_video_decoder_dev_thunk.cc:85: &Destroy}; On 2014/05/05 22:42:25, teravest wrote: > Is this ...
6 years, 7 months ago (2014-05-05 22:55:25 UTC) #4
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-05 23:14:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/263893005/30001
6 years, 7 months ago (2014-05-05 23:15:28 UTC) #6
bbudge
The CQ bit was unchecked by bbudge@chromium.org
6 years, 7 months ago (2014-05-05 23:36:19 UTC) #7
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-05 23:36:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/263893005/30001
6 years, 7 months ago (2014-05-05 23:38:55 UTC) #9
bbudge
The CQ bit was unchecked by bbudge@chromium.org
6 years, 7 months ago (2014-05-05 23:40:31 UTC) #10
bbudge
I updated the CL to rename the resource creation function to CreateVideoDecoderDev to avoid another ...
6 years, 7 months ago (2014-05-06 01:27:23 UTC) #11
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-06 01:27:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/263893005/50001
6 years, 7 months ago (2014-05-06 01:28:43 UTC) #13
bbudge
The CQ bit was unchecked by bbudge@chromium.org
6 years, 7 months ago (2014-05-06 01:29:48 UTC) #14
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-06 01:30:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/263893005/50001
6 years, 7 months ago (2014-05-06 01:33:23 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 07:08:22 UTC) #17
Message was sent while issue was closed. 
Change committed as 268450

Powered by Google App Engine
This is Rietveld 408576698