Updates touch calibration API and plumbs through the native touch calibration method

extensions/browser/api/system_display/display_info_provider.h

Index: extensions/browser/api/system_display/display_info_provider.h
diff --git a/extensions/browser/api/system_display/display_info_provider.h b/extensions/browser/api/system_display/display_info_provider.h
index 3ab6357b726e4da0e7990a1f5d82db6e9551e9f5..f27caaa3fc3637d55dce5ec93b4d419fbb60f224 100644
--- a/extensions/browser/api/system_display/display_info_provider.h
+++ b/extensions/browser/api/system_display/display_info_provider.h
@@ -10,6 +10,7 @@
 #include <string>
 #include <vector>
 
+#include "base/callback_forward.h"
 #include "base/macros.h"
 
 namespace display {
@@ -33,6 +34,7 @@ class DisplayInfoProvider {
  public:
   using DisplayUnitInfoList = std::vector<api::system_display::DisplayUnitInfo>;
   using DisplayLayoutList = std::vector<api::system_display::DisplayLayout>;
+  using TouchCalibrationCallback = base::Callback<void(bool)>;
 
   virtual ~DisplayInfoProvider();
 
@@ -75,14 +77,18 @@ class DisplayInfoProvider {
 
   // Implements touch calibration methods. See system_display.idl. This returns
   // false if |id| is invalid.
-  virtual bool TouchCalibrationStart(const std::string& id);
-  virtual bool TouchCalibrationSet(
+  virtual bool ShowNativeTouchCalibration(
       const std::string& id,
+      std::string* error,
+      const TouchCalibrationCallback& callback);
+  virtual bool StartCustomTouchCalibration(const std::string& id,
+                                           std::string* error);
+  virtual bool CompleteCustomTouchCalibration(
       const api::system_display::TouchCalibrationPairQuad& pairs,
       const api::system_display::Bounds& bounds,
       std::string* error);
-  virtual bool TouchCalibrationReset(const std::string& id, std::string* error);
-  virtual bool IsTouchCalibrationActive(std::string* error);
+  virtual bool ResetTouchCalibration(const std::string& id, std::string* error);
+  virtual bool IsNativeTouchCalibrationActive(std::string* error);

[stevenjb, 2017/01/19 17:19:01]

All of these should be documented. In particular, document when and how |error|
will be set.

[malaykeshav, 2017/01/19 23:49:07]

Adding comments where the error is being set.

[stevenjb, 2017/01/20 00:07:07]

Public methods should *always* be documented, especially virtual methods (but
not the overrides). We are obviously not great about that in this class, but we
really should improve that.

 
  protected:
   DisplayInfoProvider();