chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc - Issue 2638903003: Updates touch calibration API and plumbs through the native touch calibration method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

Issue 2638903003: Updates touch calibration API and plumbs through the native touch calibration method (Closed)

Patch Set: Resolving Comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc ('K') | « chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc ('k') | chrome/browser/extensions/display_info_provider_chromeos.h » ('j') | chrome/browser/extensions/display_info_provider_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

diff --git a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

index 080e2088beb74109f87dc4cce30df7ae94249f1b..0be213c3d07f7fbce8edbf504cc3698a5bb317eb 100644

--- a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

+++ b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

@@ -44,7 +44,9 @@ class TouchCalibratorControllerTest : public ash::test::AshTestBase {

EXPECT_FALSE(ctrl->is_calibrating());

EXPECT_FALSE(!!ctrl->touch_calibrator_views_.size());

- ctrl->StartCalibration(target_display);

+ TouchCalibratorController::TouchCalibrationCallback callback;

stevenjb 2017/01/19 17:19:01 nit: 'do_nothing' or 'empty_callback'

malaykeshav 2017/01/19 23:49:06 Done

+ ctrl->StartCalibration(target_display, callback);

EXPECT_TRUE(ctrl->is_calibrating());

// There should be a touch calibrator view associated with each of the