Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: chrome/browser/resources/settings/device_page/display.js

Issue 2638903003: Updates touch calibration API and plumbs through the native touch calibration method (Closed)
Patch Set: Resolving Comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-display' is the settings subpage for display settings. 7 * 'settings-display' is the settings subpage for display settings.
8 */ 8 */
9 9
10 cr.define('settings.display', function() { 10 cr.define('settings.display', function() {
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 onSelectDisplayTab_: function(e) { 308 onSelectDisplayTab_: function(e) {
309 this.onSelectDisplay_({detail: e.detail.item.displayId}); 309 this.onSelectDisplay_({detail: e.detail.item.displayId});
310 }, 310 },
311 311
312 /** 312 /**
313 * Handles event when a touch calibration option is selected. 313 * Handles event when a touch calibration option is selected.
314 * @param {!Event} e 314 * @param {!Event} e
315 * @private 315 * @private
316 */ 316 */
317 onTouchCalibrationTap_: function(e) { 317 onTouchCalibrationTap_: function(e) {
318 settings.display.systemDisplayApi.touchCalibrationStart( 318 settings.display.systemDisplayApi.showNativeTouchCalibration(
319 this.selectedDisplay.id); 319 this.selectedDisplay.id, function(success) {});
stevenjb 2017/01/19 17:19:01 Ideally we should disable the button while touch c
malaykeshav 2017/01/19 23:49:07 This would be a safety measure since the calibrati
320 }, 320 },
321 321
322 /** 322 /**
323 * Handles the event when an option from display select menu is selected. 323 * Handles the event when an option from display select menu is selected.
324 * @param {!{target: !HTMLSelectElement}} e 324 * @param {!{target: !HTMLSelectElement}} e
325 * @private 325 * @private
326 */ 326 */
327 updatePrimaryDisplay_: function(e) { 327 updatePrimaryDisplay_: function(e) {
328 /** @const {number} */ var PRIMARY_DISP_IDX = 0; 328 /** @const {number} */ var PRIMARY_DISP_IDX = 0;
329 if (!this.selectedDisplay) 329 if (!this.selectedDisplay)
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 }, 434 },
435 435
436 /** @private */ 436 /** @private */
437 setPropertiesCallback_: function() { 437 setPropertiesCallback_: function() {
438 if (chrome.runtime.lastError) { 438 if (chrome.runtime.lastError) {
439 console.error( 439 console.error(
440 'setDisplayProperties Error: ' + chrome.runtime.lastError.message); 440 'setDisplayProperties Error: ' + chrome.runtime.lastError.message);
441 } 441 }
442 }, 442 },
443 }); 443 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698