Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: services/ui/surfaces/display_compositor.h

Issue 2638833002: Moving temporary reference logic to SurfaceManager (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | services/ui/surfaces/display_compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/surfaces/display_compositor.h
diff --git a/services/ui/surfaces/display_compositor.h b/services/ui/surfaces/display_compositor.h
index fca74d8a19cde7f871ecb6ad92a848e36ded099f..cac807c36c3344511dce9363bce7a033cbb95a88 100644
--- a/services/ui/surfaces/display_compositor.h
+++ b/services/ui/surfaces/display_compositor.h
@@ -38,11 +38,6 @@ class SyntheticBeginFrameSource;
namespace ui {
-namespace test {
-class DisplayCompositorTest;
-}
-
-class DisplayCompositorClient;
class GpuCompositorFrameSink;
// The DisplayCompositor object is an object global to the Window Server app
@@ -97,11 +92,6 @@ class DisplayCompositor : public cc::SurfaceObserver,
cc::mojom::MojoCompositorFrameSinkClientPtr client) override;
private:
- friend class test::DisplayCompositorTest;
-
- void AddSurfaceReference(const cc::SurfaceReference& ref);
- void RemoveSurfaceReference(const cc::SurfaceReference& ref);
-
std::unique_ptr<cc::Display> CreateDisplay(
const cc::FrameSinkId& frame_sink_id,
gpu::SurfaceHandle surface_handle,
@@ -144,16 +134,6 @@ class DisplayCompositor : public cc::SurfaceObserver,
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- // SurfaceIds that have temporary references from top level root so they
- // aren't GC'd before DisplayCompositorClient can add a real reference. This
- // is basically a collection of surface ids, for example:
- // cc::SurfaceId surface_id(key, value[index]);
- // The LocalFrameIds are stored in the order the surfaces are created in.
- std::unordered_map<cc::FrameSinkId,
- std::vector<cc::LocalFrameId>,
- cc::FrameSinkIdHash>
- temp_references_;
-
base::ThreadChecker thread_checker_;
cc::mojom::DisplayCompositorClientPtr client_;
« no previous file with comments | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | services/ui/surfaces/display_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698