Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 263883008: Make sure CPU profiler collects a sample on start. (Closed)

Created:
6 years, 7 months ago by alph
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-dev
Visibility:
Public.

Description

Make sure CPU profiler collects a sample on start. BUG=369035 LOG=N R=bmeurer@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M src/cpu-profiler.cc View 1 chunk +24 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alph
ptal
6 years, 7 months ago (2014-05-05 13:49:17 UTC) #1
yurys
lgtm
6 years, 7 months ago (2014-05-05 13:57:39 UTC) #2
Benedikt Meurer
lgtm
6 years, 7 months ago (2014-05-05 17:47:38 UTC) #3
alph
The CQ bit was checked by alph@chromium.org
6 years, 7 months ago (2014-05-05 20:27:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/alph@chromium.org/263883008/1
6 years, 7 months ago (2014-05-05 20:27:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-05 20:27:49 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-05 20:27:50 UTC) #7
alph
6 years, 7 months ago (2014-05-06 08:18:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r21157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698