Issue 263883006: add release-mode checks for null, at least for a while

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263883006: add release-mode checks for null, at least for a while (Closed)

Created:
6 years, 7 months ago by reed1

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, Nico

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add release-mode checks for null, at least for a while BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14552

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	include/core/SkTLazy.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/core/SkPaint.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

lgtm, though I hope this isn't just removed by the compiler or becomes a warning ...

6 years, 7 months ago (2014-05-02 21:15:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/263883006/1

6 years, 7 months ago (2014-05-02 21:15:54 UTC) #4

Nico

Can this be removed again? It looks like the bug this refers to was fixed ...

6 years, 6 months ago (2014-06-07 17:19:08 UTC) #6

Nico

6 years, 6 months ago (2014-06-07 23:55:50 UTC) #7

Message was sent while issue was closed.

On 2014/06/07 17:19:08, Nico (away) wrote:
> Can this be removed again? It looks like the bug this refers to was fixed in
> another way, and a new clang now warns that references will never be null (and
> optimizes this check away because of that): http://crbug.com/381910

mtklein took care of this here: https://codereview.chromium.org/325603002/

Expand Messages | Collapse Messages