Renamed app list position flag to --enable-centered-app-list.

Renamed app list position flag to --enable-centered-app-list.

Previous name was --enable-experimental-app-list-position.

We will soon be using this on real devices without the flag under
certain conditions (when the virtual keyboard is enabled), so it is no
longer experimental.

Updated strings and internal constant/function names to match.

BUG=369382
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267844

[Matt Giuca, 2014-05-02 03:25:00]

As requested on the other CL.

[Matt Giuca, 2014-05-02 03:27:18]

+calamity, FYI.

[varkha, 2014-05-02 03:43:57]

lgtm.

[benwells, 2014-05-02 04:42:12]

https://codereview.chromium.org/263883002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/263883002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6573: +        <message
name="IDS_FLAGS_CENTER_APP_LIST_DESCRIPTION" desc="Description of the flag to
center the app launcher and make it wide instead of tall.">
Flags should all be ...ENABLE_BLAH (or ...DISABLE_...). So this one should be
IDS_ENABLE_CENTERED_APP_LIST...

[Matt Giuca, 2014-05-02 05:15:02]

PTAL.

https://codereview.chromium.org/263883002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/263883002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6573: +        <message
name="IDS_FLAGS_CENTER_APP_LIST_DESCRIPTION" desc="Description of the flag to
center the app launcher and make it wide instead of tall.">
On 2014/05/02 04:42:13, benwells wrote:
> Flags should all be ...ENABLE_BLAH (or ...DISABLE_...). So this one should be
> IDS_ENABLE_CENTERED_APP_LIST...

Done.

[benwells, 2014-05-02 05:52:38]

lgtm

https://codereview.chromium.org/263883002/diff/40001/ui/app_list/app_list_swi...
File ui/app_list/app_list_switches.cc (right):

https://codereview.chromium.org/263883002/diff/40001/ui/app_list/app_list_swi...
ui/app_list/app_list_switches.cc:66: bool IsAppListCentered() {
Nit: rename to IsCenteredAppListEnabled.

[Matt Giuca, 2014-05-02 06:06:30]

https://codereview.chromium.org/263883002/diff/40001/ui/app_list/app_list_swi...
File ui/app_list/app_list_switches.cc (right):

https://codereview.chromium.org/263883002/diff/40001/ui/app_list/app_list_swi...
ui/app_list/app_list_switches.cc:66: bool IsAppListCentered() {
On 2014/05/02 05:52:38, benwells wrote:
> Nit: rename to IsCenteredAppListEnabled.

Done.

[Matt Giuca, 2014-05-02 06:07:10]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-02 06:07:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/263883002/50001

[commit-bot: I haz the power, 2014-05-02 06:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 06:43:49]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium

[Matt Giuca, 2014-05-02 07:58:53]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-02 07:59:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/263883002/50001

[commit-bot: I haz the power, 2014-05-02 17:35:58]

Change committed as 267844