Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: java/org/chromium/distiller/webdocument/WebTable.java

Issue 2638823002: Support <picture> in image extraction (Closed)
Patch Set: support lazy loading in <picture> Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: java/org/chromium/distiller/webdocument/WebTable.java
diff --git a/java/org/chromium/distiller/webdocument/WebTable.java b/java/org/chromium/distiller/webdocument/WebTable.java
index 48ed32d0dc2a5c97a8b33601d1d889228423ab9f..06ee861a4ee7ea44b54156ac807aa2b8190ba16d 100644
--- a/java/org/chromium/distiller/webdocument/WebTable.java
+++ b/java/org/chromium/distiller/webdocument/WebTable.java
@@ -51,11 +51,13 @@ public class WebTable extends WebElement {
cloneAndProcessNode();
}
List<String> imgUrls = new ArrayList<>();
- NodeList<Element> imgs = DomUtil.querySelectorAll(cloned, "IMG");
+ NodeList<Element> imgs = DomUtil.querySelectorAll(cloned, "IMG, SOURCE");
for (int i = 0; i < imgs.getLength(); i++) {
ImageElement ie = (ImageElement) imgs.getItem(i);
- imgUrls.add(ie.getSrc());
- imgUrls.addAll(DomUtil.getSrcSetUrls(ie));
+ if (!ie.getSrc().isEmpty()) {
+ imgUrls.add(ie.getSrc());
+ }
+ imgUrls.addAll(DomUtil.getAllSrcSetUrls(ie));
}
return imgUrls;
}
« no previous file with comments | « java/org/chromium/distiller/webdocument/WebImage.java ('k') | javatests/org/chromium/distiller/ContentExtractorTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698