Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: javatests/org/chromium/distiller/webdocument/WebImageTest.java

Issue 2638823002: Support <picture> in image extraction (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: javatests/org/chromium/distiller/webdocument/WebImageTest.java
diff --git a/javatests/org/chromium/distiller/webdocument/WebImageTest.java b/javatests/org/chromium/distiller/webdocument/WebImageTest.java
index 406db952989789ee01224e68be3a402831ef3186..bbe54fb39eb1481bb4855c0576b21ae082a6c4a3 100644
--- a/javatests/org/chromium/distiller/webdocument/WebImageTest.java
+++ b/javatests/org/chromium/distiller/webdocument/WebImageTest.java
@@ -9,14 +9,18 @@ import org.chromium.distiller.DomDistillerJsTestCase;
import java.util.List;
import com.google.gwt.dom.client.Document;
+import com.google.gwt.dom.client.Element;
import com.google.gwt.dom.client.ImageElement;
+import org.chromium.distiller.DomUtil;
public class WebImageTest extends DomDistillerJsTestCase {
public void testGetSrcList() {
+ mHead.setInnerHTML("<base href=\"http://example.com/\">");
+
ImageElement img = Document.get().createImageElement();
- img.setSrc("http://example.com/image");
+ img.setSrc("image");
img.setAttribute("srcset",
- "http://example.com/image200 200w, http://example.com/image400 400w");
+ "image200 200w, image400 400w");
WebImage wi = new WebImage(img, 1, 1, img.getSrc());
List<String> urls = wi.getUrlList();
assertEquals(3, urls.size());
@@ -24,4 +28,25 @@ public class WebImageTest extends DomDistillerJsTestCase {
assertEquals("http://example.com/image200", urls.get(1));
assertEquals("http://example.com/image400", urls.get(2));
}
+
+ public void testGetSrcListInPicture() {
+ mHead.setInnerHTML("<base href=\"http://example.com/\">");
+
+ String html =
+ "<picture>" +
+ "<source srcset=\"image200 200w, //example.org/image400 400w\">" +
+ "<source srcset=\"image100 100w, //example.org/image300 300w\">" +
+ "<img>" +
+ "</picture>";
+ Element container = Document.get().createDivElement();
+ container.setInnerHTML(html);
+ WebImage wi = new WebImage(container.getFirstChildElement(), 1, 1, "");
+ List<String> urls = wi.getUrlList();
+ //assertEquals("", wi.generateOutput(false));
mdjones 2017/01/17 17:41:47 Remove commented line.
wychen 2017/01/18 17:29:54 Done.
+ assertEquals(4, urls.size());
+ assertEquals("http://example.com/image200", urls.get(0));
+ assertEquals("http://example.org/image400", urls.get(1));
+ assertEquals("http://example.com/image100", urls.get(2));
+ assertEquals("http://example.org/image300", urls.get(3));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698